From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <Wright.Feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Double Lo <Double.Lo@cypress.com>
Subject: Re: [PATCH 2/2] brcmfmac: support wake on ping packet
Date: Fri, 4 Jan 2019 13:17:28 +0100 [thread overview]
Message-ID: <cad34d20-efd1-63c5-6981-cd87794259a4@broadcom.com> (raw)
In-Reply-To: <1546501565-40752-3-git-send-email-chi-hsien.lin@cypress.com>
On 1/3/2019 8:46 AM, Chi-Hsien Lin wrote:
> From: Lo-Hsiang Lo <double.lo@cypress.com>
>
> Set up wiphy->wowlan_config and a dummy wowlan filter so brcmfmac can
> remain connected during suspend. Enable an unicast packet filter during
> suspend so ping packets can wake up the system.
This basically enables a default wowlan configuration, but why do we
want this in the driver. The struct wiphy::wowlan_config member is
primarily managed by cfg80211 (see nl80211_set_wowlan()) upon user-space
request.
If user-space reconfigures with no wowlan triggers the default
configuration is freed, but as we have no .set_wakeup() callback the
configuration in firmware remains unchanged so things are out of sync.
So I would discourage this default approach and just let user-space deal
with wowlan configuration.
Regards,
Arend
next prev parent reply other threads:[~2019-01-04 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 7:46 [PATCH 0/2] brcmfmac: wake on wireless LAN changes Chi-Hsien Lin
2019-01-03 7:46 ` [PATCH 1/2] brcmfmac: fix system warning message during wowl suspend Chi-Hsien Lin
2019-01-03 9:56 ` James Hughes
2019-01-07 9:16 ` Chi-Hsien Lin
2019-01-04 11:37 ` Arend Van Spriel
2019-01-03 7:46 ` [PATCH 2/2] brcmfmac: support wake on ping packet Chi-Hsien Lin
2019-01-04 12:17 ` Arend Van Spriel [this message]
2019-01-07 8:46 ` Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad34d20-efd1-63c5-6981-cd87794259a4@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=Double.Lo@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).