* [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq()
@ 2019-09-25 20:49 Denis Efremov
2019-09-30 6:46 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2019-09-25 20:49 UTC (permalink / raw)
To: Kalle Valo
Cc: Denis Efremov, Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel
There is no need to check 'priv->bt_ant_couple_ok' twice in
rs_bt_update_lq(). The second check is always true. Thus, the
expression can be simplified.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
index 74229fcb63a9..226165db7dfd 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
@@ -851,7 +851,7 @@ static void rs_bt_update_lq(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
* Is there a need to switch between
* full concurrency and 3-wire?
*/
- if (priv->bt_ci_compliance && priv->bt_ant_couple_ok)
+ if (priv->bt_ci_compliance)
full_concurrent = true;
else
full_concurrent = false;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq()
2019-09-25 20:49 [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq() Denis Efremov
@ 2019-09-30 6:46 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2019-09-30 6:46 UTC (permalink / raw)
To: Denis Efremov, Kalle Valo
Cc: Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless,
David S. Miller, linux-wireless, netdev, linux-kernel
On Wed, 2019-09-25 at 23:49 +0300, Denis Efremov wrote:
> There is no need to check 'priv->bt_ant_couple_ok' twice in
> rs_bt_update_lq(). The second check is always true. Thus, the
> expression can be simplified.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
> index 74229fcb63a9..226165db7dfd 100644
> --- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
> +++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
> @@ -851,7 +851,7 @@ static void rs_bt_update_lq(struct iwl_priv *priv, struct iwl_rxon_context *ctx,
> * Is there a need to switch between
> * full concurrency and 3-wire?
> */
> - if (priv->bt_ci_compliance && priv->bt_ant_couple_ok)
> + if (priv->bt_ci_compliance)
> full_concurrent = true;
> else
> full_concurrent = false;
Thanks, Denis! I have applied this to our internal tree and it will
reach the mainline following our usual upstreaming process.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-30 6:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 20:49 [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq() Denis Efremov
2019-09-30 6:46 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).