From: Wen Gong <wgong@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver
Date: Tue, 15 Sep 2020 20:32:53 +0800 [thread overview]
Message-ID: <e08a20b99363d68626bc38b6e3d2fcfd@codeaurora.org> (raw)
In-Reply-To: <a5cac45b02396c98628738cef7f92ad1@codeaurora.org>
On 2020-09-15 19:16, Wen Gong wrote:
> On 2020-06-03 08:17, Pradeep Kumar Chitrapu wrote:
>> This patch adds 6GHz band support and mac80211 registration for
>> the 6G phy radio.
>>
>> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>> ---
>> v5:
>> - do not add ht/vht caps in 6ghz band.
>> v3:
>> - update 6GHz starting frequency as defined in IEEE P802.11ax/D6.1
>>
>> drivers/net/wireless/ath/ath11k/core.h | 6 +-
>> drivers/net/wireless/ath/ath11k/mac.c | 93
>> +++++++++++++++++++++-----
>> drivers/net/wireless/ath/ath11k/wmi.c | 16 ++++-
>> 3 files changed, 94 insertions(+), 21 deletions(-)
>>
> [...]
>> @@ -3482,7 +3494,7 @@ static void ath11k_mac_setup_ht_vht_cap(struct
>> ath11k *ar,
>> rate_cap_rx_chainmask);
>> }
>>
>> - if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) {
>> + if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP &&
>> !ar->supports_6ghz) {
>> band = &ar->mac.sbands[NL80211_BAND_5GHZ];
>> ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info;
>> if (ht_cap_info)
> After this change, when 6G is support, it removed HT/VHT of 5G band
> from "iw list", when connect to an 11AX AP of 5G, it used non-HT.
> caused together with this commit
> 75e296e9b22aef6fa467523ace87ef623dac1fad(mac80211: simplify and
> improve HT/VHT/HE disable code)
> + /* disable HT/VHT/HE if we don't support them */
> + if (!sband->ht_cap.ht_supported) {
> + ifmgd->flags |= IEEE80211_STA_DISABLE_HT;
> + ifmgd->flags |= IEEE80211_STA_DISABLE_VHT;
> + ifmgd->flags |= IEEE80211_STA_DISABLE_HE;
> + }
>
> after remove this change in ath11k, it become correct to HE
> iw wls1 station dump:
> rx bitrate: 149.7 MBit/s HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0
>
Hi Pradeep Kumar Chitrapu,
For QCA6390, it is single_pdev, the pdev support all 2G/5G/6G,
Is it have 3 pdev/ath11k in your chip for 2G/5G/6G?
And the pdev/ath11k of 6G have WMI_HOST_WLAN_5G_CAP of
cap->supported_bands?
> [...]
next prev parent reply other threads:[~2020-09-15 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 0:17 [PATCH v5 0/8] add 6GHz radio support in ath11k driver Pradeep Kumar Chitrapu
2020-06-03 0:17 ` [PATCH v5 1/8] ath11k: add 6G frequency list supported by driver Pradeep Kumar Chitrapu
2020-06-08 15:41 ` Kalle Valo
2020-06-11 5:06 ` Kalle Valo
2020-06-03 0:17 ` [PATCH v5 2/8] ath11k: add support for 6GHz radio in driver Pradeep Kumar Chitrapu
2020-09-15 11:16 ` Wen Gong
2020-09-15 12:32 ` Wen Gong [this message]
2020-09-15 23:07 ` Pradeep Kumar Chitrapu
2020-09-16 2:33 ` Wen Gong
2020-09-16 3:56 ` Wen Gong
2020-06-03 0:17 ` [PATCH v5 3/8] ath11k: Use freq instead of channel number in rx path Pradeep Kumar Chitrapu
2020-06-03 0:17 ` [PATCH v5 4/8] ath11k: extend peer_assoc_cmd for 6GHz band Pradeep Kumar Chitrapu
2020-06-03 0:17 ` [PATCH v5 5/8] ath11k: set psc channel flag when sending channel list to firmware Pradeep Kumar Chitrapu
2020-06-03 0:17 ` [PATCH v5 6/8] ath11k: Add 6G scan dwell time parameter in scan request command Pradeep Kumar Chitrapu
2020-06-03 0:17 ` [PATCH v5 7/8] ath11k: Send multiple scan_chan_list messages if required Pradeep Kumar Chitrapu
2020-06-09 6:37 ` Kalle Valo
2020-06-03 0:17 ` [PATCH v5 8/8] ath11k: Add support for 6g scan hint Pradeep Kumar Chitrapu
2020-08-24 3:29 ` Wen Gong
2020-09-09 8:38 ` Kalle Valo
2020-06-03 13:12 ` [PATCH v5 0/8] add 6GHz radio support in ath11k driver Kalle Valo
2020-06-03 17:50 ` Pradeep Kumar Chitrapu
2020-06-08 11:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08a20b99363d68626bc38b6e3d2fcfd@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).