* [PATCH] mt76: mt7615: stop mcu first in mt7615_unregister_device
[not found] <cover.1557836235.git.lorenzo@kernel.org>
@ 2019-05-14 12:20 ` Lorenzo Bianconi
2019-06-07 16:34 ` Felix Fietkau
0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2019-05-14 12:20 UTC (permalink / raw)
To: nbd; +Cc: lorenzo.bianconi, linux-wireless, ryder.lee, royluo
Stop mcu engine and then dma one in mt7615_unregister_device
in order to avoid a mcu hang in mt7615_unregister_device
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
This patch ca be squashed with 'mt76: mt7615: rearrange cleanup operations in
mt7615_unregister_device' since it is not upstream yet
---
drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index 59f604f3161f..369b9a8e07be 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -213,8 +213,8 @@ void mt7615_unregister_device(struct mt7615_dev *dev)
int id;
mt76_unregister_device(&dev->mt76);
- mt7615_dma_cleanup(dev);
mt7615_mcu_exit(dev);
+ mt7615_dma_cleanup(dev);
spin_lock_bh(&dev->token_lock);
idr_for_each_entry(&dev->token, txwi, id) {
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: mt7615: stop mcu first in mt7615_unregister_device
2019-05-14 12:20 ` [PATCH] mt76: mt7615: stop mcu first in mt7615_unregister_device Lorenzo Bianconi
@ 2019-06-07 16:34 ` Felix Fietkau
0 siblings, 0 replies; 2+ messages in thread
From: Felix Fietkau @ 2019-06-07 16:34 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: lorenzo.bianconi, linux-wireless, ryder.lee, royluo
On 2019-05-14 14:20, Lorenzo Bianconi wrote:
> Stop mcu engine and then dma one in mt7615_unregister_device
> in order to avoid a mcu hang in mt7615_unregister_device
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> This patch ca be squashed with 'mt76: mt7615: rearrange cleanup operations in
> mt7615_unregister_device' since it is not upstream yet
Applied, thanks.
- Felix
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-07 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1557836235.git.lorenzo@kernel.org>
2019-05-14 12:20 ` [PATCH] mt76: mt7615: stop mcu first in mt7615_unregister_device Lorenzo Bianconi
2019-06-07 16:34 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).