* Re: [GIT PULL] Networking for v5.15 [not found] <20210831203727.3852294-1-kuba@kernel.org> @ 2021-09-01 19:00 ` Linus Torvalds 2021-09-01 19:41 ` Jakub Kicinski 0 siblings, 1 reply; 8+ messages in thread From: Linus Torvalds @ 2021-09-01 19:00 UTC (permalink / raw) To: Jakub Kicinski, Luca Coelho, Kalle Valo Cc: David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski <kuba@kernel.org> wrote: > > No conflicts at the time of writing. There were conflicts with > char-misc but I believe Greg dropped the commits in question. Hmm. I already merged this earlier, but didn't notice a new warning on my desktop: RTNL: assertion failed at net/wireless/reg.c (4025) WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:4025 regulatory_set_wiphy_regd_sync+0x7f/0x90 [cfg80211] Call Trace: iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/reg.c (3106) WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:3106 reg_process_self_managed_hint+0x26c/0x280 [cfg80211] Call Trace: regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/core.c (84) WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:84 wiphy_idx_to_wiphy+0x97/0xd0 [cfg80211] Call Trace: nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] reg_process_self_managed_hint+0x23d/0x280 [cfg80211] regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/core.c (61) WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61 wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211] Call Trace: nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] reg_process_self_managed_hint+0x23d/0x280 [cfg80211] regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] They all seem to have that same issue, and it looks like the fix would be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look into it very much. This is on my desktop, and I actually don't _use_ the wireless on this machine. I assume it still works despite the warnings, but they should get fixed. I *don't* see these warnings on my laptop where I actually use wireless, but that one uses ath10k_pci, so it seems this is purely a iwlwifi issue. I can't be the only one that sees this. Hmm? Linus ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-01 19:00 ` [GIT PULL] Networking for v5.15 Linus Torvalds @ 2021-09-01 19:41 ` Jakub Kicinski 2021-09-01 19:49 ` Johannes Berg 2021-09-02 5:55 ` Larry Finger 0 siblings, 2 replies; 8+ messages in thread From: Jakub Kicinski @ 2021-09-01 19:41 UTC (permalink / raw) To: Linus Torvalds Cc: Luca Coelho, Kalle Valo, David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless, Miri Korenblit, Johannes Berg On Wed, 1 Sep 2021 12:00:57 -0700 Linus Torvalds wrote: > On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > > No conflicts at the time of writing. There were conflicts with > > char-misc but I believe Greg dropped the commits in question. > > Hmm. I already merged this earlier, but didn't notice a new warning on > my desktop: > RTNL: assertion failed at net/wireless/core.c (61) > WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61 > wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211] > Call Trace: > nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] > reg_process_self_managed_hint+0x23d/0x280 [cfg80211] > regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] > iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] > iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] > iwl_opmode_register+0xd0/0x130 [iwlwifi] > init_module+0x23/0x1000 [iwlmvm] > > They all seem to have that same issue, and it looks like the fix would > be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look > into it very much. > > This is on my desktop, and I actually don't _use_ the wireless on this > machine. I assume it still works despite the warnings, but they should > get fixed. > > I *don't* see these warnings on my laptop where I actually use > wireless, but that one uses ath10k_pci, so it seems this is purely a > iwlwifi issue. > > I can't be the only one that sees this. Hmm? Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). CC Miri, Johannes ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-01 19:41 ` Jakub Kicinski @ 2021-09-01 19:49 ` Johannes Berg 2021-09-01 21:48 ` Larry Finger 2021-09-02 9:33 ` Coelho, Luciano 2021-09-02 5:55 ` Larry Finger 1 sibling, 2 replies; 8+ messages in thread From: Johannes Berg @ 2021-09-01 19:49 UTC (permalink / raw) To: Jakub Kicinski, Linus Torvalds Cc: Luca Coelho, Kalle Valo, David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless, Miri Korenblit On Wed, 2021-09-01 at 12:41 -0700, Jakub Kicinski wrote: > > > > > They all seem to have that same issue, and it looks like the fix would > > be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look > > into it very much. > > > > This is on my desktop, and I actually don't _use_ the wireless on this > > machine. I assume it still works despite the warnings, but they should > > get fixed. > > > > I *don't* see these warnings on my laptop where I actually use > > wireless, but that one uses ath10k_pci, so it seems this is purely a > > iwlwifi issue. > > > > I can't be the only one that sees this. Hmm? > > Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() > in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). Huh! That's not the version of the commit I remember - it had an rtnl_lock() in there too (just before the mutex_lock)?! Looks like that should really be there, not sure how/where it got lost along the way. That unbalanced rtnl_unlock() makes no sense anyway. Wonder why it doesn't cause more assertions/problems at that point, clearly it's unbalanced. Pretty sure it's missing the rtnl_lock() earlier in the function for some reason. Luca and I will look at it tomorrow, getting late here, sorry. johannes ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-01 19:49 ` Johannes Berg @ 2021-09-01 21:48 ` Larry Finger 2021-09-02 9:33 ` Coelho, Luciano 1 sibling, 0 replies; 8+ messages in thread From: Larry Finger @ 2021-09-01 21:48 UTC (permalink / raw) To: Johannes Berg, Jakub Kicinski, Linus Torvalds Cc: Luca Coelho, Kalle Valo, David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless, Miri Korenblit On 9/1/21 14:49, Johannes Berg wrote: > On Wed, 2021-09-01 at 12:41 -0700, Jakub Kicinski wrote: >> >>> >>> They all seem to have that same issue, and it looks like the fix would >>> be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look >>> into it very much. >>> >>> This is on my desktop, and I actually don't _use_ the wireless on this >>> machine. I assume it still works despite the warnings, but they should >>> get fixed. >>> >>> I *don't* see these warnings on my laptop where I actually use >>> wireless, but that one uses ath10k_pci, so it seems this is purely a >>> iwlwifi issue. >>> >>> I can't be the only one that sees this. Hmm? >> >> Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() >> in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). > > Huh! That's not the version of the commit I remember - it had an > rtnl_lock() in there too (just before the mutex_lock)?! Looks like that > should really be there, not sure how/where it got lost along the way. > > That unbalanced rtnl_unlock() makes no sense anyway. Wonder why it > doesn't cause more assertions/problems at that point, clearly it's > unbalanced. Pretty sure it's missing the rtnl_lock() earlier in the > function for some reason. > > Luca and I will look at it tomorrow, getting late here, sorry. > > johannes > I am seeing the same problem, and it does happen in lots of places. For example finger@2603-8090-2005-39b3-0000-0000-0000-1023:~/rtl8812au>dmesg | grep assertion\ failed [ 6.465589] RTNL: assertion failed at net/core/rtnetlink.c (1702) [ 6.465948] RTNL: assertion failed at net/core/devlink.c (11496) [ 6.466263] RTNL: assertion failed at net/core/rtnetlink.c (1412) [ 6.466500] RTNL: assertion failed at net/core/dev.c (1987) [ 6.466708] RTNL: assertion failed at net/core/fib_rules.c (1227) [ 6.466902] RTNL: assertion failed at net/ipv4/devinet.c (1526) [ 6.467097] RTNL: assertion failed at net/ipv4/igmp.c (1779) [ 6.467291] RTNL: assertion failed at net/ipv4/igmp.c (1432) I am in the process of bisecting the problem, just in case it happens some other place than your suspicion leads you. Larry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-01 19:49 ` Johannes Berg 2021-09-01 21:48 ` Larry Finger @ 2021-09-02 9:33 ` Coelho, Luciano [not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com> 1 sibling, 1 reply; 8+ messages in thread From: Coelho, Luciano @ 2021-09-02 9:33 UTC (permalink / raw) To: torvalds, johannes, kuba Cc: linux-wireless, Korenblit, Miriam Rachel, linux-kernel, gregkh, kvalo, davem, netdev On Wed, 2021-09-01 at 21:49 +0200, Johannes Berg wrote: > On Wed, 2021-09-01 at 12:41 -0700, Jakub Kicinski wrote: > > > > > > > > They all seem to have that same issue, and it looks like the fix would > > > be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look > > > into it very much. > > > > > > This is on my desktop, and I actually don't _use_ the wireless on this > > > machine. I assume it still works despite the warnings, but they should > > > get fixed. > > > > > > I *don't* see these warnings on my laptop where I actually use > > > wireless, but that one uses ath10k_pci, so it seems this is purely a > > > iwlwifi issue. > > > > > > I can't be the only one that sees this. Hmm? > > > > Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() > > in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). > > Huh! That's not the version of the commit I remember - it had an > rtnl_lock() in there too (just before the mutex_lock)?! Looks like that > should really be there, not sure how/where it got lost along the way. > > That unbalanced rtnl_unlock() makes no sense anyway. Wonder why it > doesn't cause more assertions/problems at that point, clearly it's > unbalanced. Pretty sure it's missing the rtnl_lock() earlier in the > function for some reason. > > Luca and I will look at it tomorrow, getting late here, sorry. Right, the reason for this was a rebase damage. We lost the rtnl_lock() call when I rebased the patch on top of the tree without iwlmei (which touch this same function). Sorry for the trouble, I'll send the fix in a sec. -- Cheers, Luca. ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>]
* Re: [GIT PULL] Networking for v5.15 [not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com> @ 2021-09-02 17:16 ` Linus Torvalds 0 siblings, 0 replies; 8+ messages in thread From: Linus Torvalds @ 2021-09-02 17:16 UTC (permalink / raw) To: Larry Finger Cc: Coelho, Luciano, johannes, kuba, linux-wireless, Korenblit, Miriam Rachel, linux-kernel, gregkh, kvalo, davem, netdev On Thu, Sep 2, 2021 at 10:07 AM Larry Finger <Larry.Finger@lwfinger.net> wrote: > > I can confirm that Luca's patch fixes the problem on my system. Yes. It's merged in my tree as commit 75ae663d053b ("iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm()"), and I no longer see the complaints. Linus ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-01 19:41 ` Jakub Kicinski 2021-09-01 19:49 ` Johannes Berg @ 2021-09-02 5:55 ` Larry Finger 2021-09-02 7:07 ` Johannes Berg 1 sibling, 1 reply; 8+ messages in thread From: Larry Finger @ 2021-09-02 5:55 UTC (permalink / raw) To: Jakub Kicinski, Linus Torvalds Cc: Luca Coelho, Kalle Valo, David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless, Miri Korenblit, Johannes Berg On 9/1/21 14:41, Jakub Kicinski wrote: > On Wed, 1 Sep 2021 12:00:57 -0700 Linus Torvalds wrote: >> On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski <kuba@kernel.org> wrote: >>> >>> No conflicts at the time of writing. There were conflicts with >>> char-misc but I believe Greg dropped the commits in question. >> >> Hmm. I already merged this earlier, but didn't notice a new warning on >> my desktop: > >> RTNL: assertion failed at net/wireless/core.c (61) >> WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61 >> wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211] >> Call Trace: >> nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] >> reg_process_self_managed_hint+0x23d/0x280 [cfg80211] >> regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] >> iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] >> iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] >> iwl_opmode_register+0xd0/0x130 [iwlwifi] >> init_module+0x23/0x1000 [iwlmvm] >> >> They all seem to have that same issue, and it looks like the fix would >> be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look >> into it very much. >> >> This is on my desktop, and I actually don't _use_ the wireless on this >> machine. I assume it still works despite the warnings, but they should >> get fixed. >> >> I *don't* see these warnings on my laptop where I actually use >> wireless, but that one uses ath10k_pci, so it seems this is purely a >> iwlwifi issue. >> >> I can't be the only one that sees this. Hmm? > > Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() > in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). > > CC Miri, Johannes > I did not get the bisection finished tonight, but commit eb09ae93dabf is not the problem. My bisection has identified commit 7a3f5b0de36 ("netfilter: add netfilter hooks to SRv6 data plane") as bad, and commit 9055a2f59162 ("ixp4xx_eth: make ptp support a platform driver") as good. Larry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] Networking for v5.15 2021-09-02 5:55 ` Larry Finger @ 2021-09-02 7:07 ` Johannes Berg 0 siblings, 0 replies; 8+ messages in thread From: Johannes Berg @ 2021-09-02 7:07 UTC (permalink / raw) To: Larry Finger, Jakub Kicinski, Linus Torvalds Cc: Luca Coelho, Kalle Valo, David Miller, Netdev, Linux Kernel Mailing List, Greg Kroah-Hartman, linux-wireless, Miri Korenblit On Thu, 2021-09-02 at 00:55 -0500, Larry Finger wrote: > > I did not get the bisection finished tonight, but commit eb09ae93dabf is not the > problem. > > My bisection has identified commit 7a3f5b0de36 ("netfilter: add netfilter hooks > to SRv6 data plane") as bad, and commit 9055a2f59162 ("ixp4xx_eth: make ptp > support a platform driver") as good. Can you send the backtraces from the RTNL assertions you posted? Probably easier that way anyway. johannes ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-02 17:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20210831203727.3852294-1-kuba@kernel.org> 2021-09-01 19:00 ` [GIT PULL] Networking for v5.15 Linus Torvalds 2021-09-01 19:41 ` Jakub Kicinski 2021-09-01 19:49 ` Johannes Berg 2021-09-01 21:48 ` Larry Finger 2021-09-02 9:33 ` Coelho, Luciano [not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com> 2021-09-02 17:16 ` Linus Torvalds 2021-09-02 5:55 ` Larry Finger 2021-09-02 7:07 ` Johannes Berg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).