* [PATCH] rtlwifi: Remove unused dummy function
@ 2017-06-28 12:32 Souptick Joarder
2017-07-04 12:22 ` Souptick Joarder
2017-07-28 15:42 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Souptick Joarder @ 2017-06-28 12:32 UTC (permalink / raw)
To: Larry.Finger, chaoming_li; +Cc: linux-wireless
Removing unused dummy function
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 ------------
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 ---
3 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
index 96c923b..62d9214 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
@@ -173,7 +173,7 @@ static bool rtl92cu_get_btc_status(void)
.rx_urb_num = RTL92C_NUM_RX_URBS,
.rx_max_size = RTL92C_SIZE_MAX_RX_BUFFER,
.usb_rx_hdl = rtl8192cu_rx_hdl,
- .usb_rx_segregate_hdl = NULL, /* rtl8192c_rx_segregate_hdl; */
+ .usb_rx_segregate_hdl = NULL,
/* tx */
.usb_tx_cleanup = rtl8192c_tx_cleanup,
.usb_tx_post_hdl = rtl8192c_tx_post_hdl,
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
index 41422e4..25a081c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
@@ -436,13 +436,6 @@ void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb)
_rtl_rx_process(hw, skb);
}
-void rtl8192c_rx_segregate_hdl(
- struct ieee80211_hw *hw,
- struct sk_buff *skb,
- struct sk_buff_head *skb_list)
-{
-}
-
/*----------------------------------------------------------------------
*
* Tx handler
@@ -675,8 +668,3 @@ void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD, "H2C Tx Cmd Content",
pdesc, RTL_TX_DESC_SIZE);
}
-
-bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
-{
- return true;
-}
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
index 487eec8..15a66c5 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
@@ -385,8 +385,6 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw,
struct ieee80211_rx_status *rx_status,
u8 *p_desc, struct sk_buff *skb);
void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb);
-void rtl8192c_rx_segregate_hdl(struct ieee80211_hw *, struct sk_buff *,
- struct sk_buff_head *);
void rtl8192c_tx_cleanup(struct ieee80211_hw *hw, struct sk_buff *skb);
int rtl8192c_tx_post_hdl(struct ieee80211_hw *hw, struct urb *urb,
struct sk_buff *skb);
@@ -404,6 +402,5 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 * pDesc,
void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
u8 *pdesc, bool b_firstseg,
bool b_lastseg, struct sk_buff *skb);
-bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Remove unused dummy function
2017-06-28 12:32 [PATCH] rtlwifi: Remove unused dummy function Souptick Joarder
@ 2017-07-04 12:22 ` Souptick Joarder
2017-07-04 13:12 ` Kalle Valo
2017-07-04 16:27 ` Larry Finger
2017-07-28 15:42 ` Kalle Valo
1 sibling, 2 replies; 5+ messages in thread
From: Souptick Joarder @ 2017-07-04 12:22 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo; +Cc: linux-wireless
Any Comment for this patch ?
On Wed, Jun 28, 2017 at 6:02 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Removing unused dummy function
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 ------------
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 ---
> 3 files changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> index 96c923b..62d9214 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> @@ -173,7 +173,7 @@ static bool rtl92cu_get_btc_status(void)
> .rx_urb_num = RTL92C_NUM_RX_URBS,
> .rx_max_size = RTL92C_SIZE_MAX_RX_BUFFER,
> .usb_rx_hdl = rtl8192cu_rx_hdl,
> - .usb_rx_segregate_hdl = NULL, /* rtl8192c_rx_segregate_hdl; */
> + .usb_rx_segregate_hdl = NULL,
> /* tx */
> .usb_tx_cleanup = rtl8192c_tx_cleanup,
> .usb_tx_post_hdl = rtl8192c_tx_post_hdl,
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> index 41422e4..25a081c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> @@ -436,13 +436,6 @@ void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb)
> _rtl_rx_process(hw, skb);
> }
>
> -void rtl8192c_rx_segregate_hdl(
> - struct ieee80211_hw *hw,
> - struct sk_buff *skb,
> - struct sk_buff_head *skb_list)
> -{
> -}
> -
> /*----------------------------------------------------------------------
> *
> * Tx handler
> @@ -675,8 +668,3 @@ void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD, "H2C Tx Cmd Content",
> pdesc, RTL_TX_DESC_SIZE);
> }
> -
> -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> -{
> - return true;
> -}
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
> index 487eec8..15a66c5 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
> @@ -385,8 +385,6 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw,
> struct ieee80211_rx_status *rx_status,
> u8 *p_desc, struct sk_buff *skb);
> void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb);
> -void rtl8192c_rx_segregate_hdl(struct ieee80211_hw *, struct sk_buff *,
> - struct sk_buff_head *);
> void rtl8192c_tx_cleanup(struct ieee80211_hw *hw, struct sk_buff *skb);
> int rtl8192c_tx_post_hdl(struct ieee80211_hw *hw, struct urb *urb,
> struct sk_buff *skb);
> @@ -404,6 +402,5 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 * pDesc,
> void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
> u8 *pdesc, bool b_firstseg,
> bool b_lastseg, struct sk_buff *skb);
> -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb);
>
> #endif
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Remove unused dummy function
2017-07-04 12:22 ` Souptick Joarder
@ 2017-07-04 13:12 ` Kalle Valo
2017-07-04 16:27 ` Larry Finger
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2017-07-04 13:12 UTC (permalink / raw)
To: Souptick Joarder; +Cc: Larry Finger, Chaoming Li, linux-wireless
Souptick Joarder <jrdr.linux@gmail.com> writes:
> Any Comment for this patch ?
Please don't top most and include the whole patch in the reply. It
clutters the patchwork among others.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rtlwifi: Remove unused dummy function
2017-07-04 12:22 ` Souptick Joarder
2017-07-04 13:12 ` Kalle Valo
@ 2017-07-04 16:27 ` Larry Finger
1 sibling, 0 replies; 5+ messages in thread
From: Larry Finger @ 2017-07-04 16:27 UTC (permalink / raw)
To: Souptick Joarder, Chaoming Li, Kalle Valo; +Cc: linux-wireless
On 07/04/2017 07:22 AM, Souptick Joarder wrote:
> Any Comment for this patch ?
If you keep bugging me about your patches, I will automatically NACK them.
I have more important things to do than reviewing your patches.
FYI, Chaoming Li no longer works on these drivers.
Larry
>
> On Wed, Jun 28, 2017 at 6:02 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Removing unused dummy function
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
>> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 ------------
>> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 ---
>> 3 files changed, 1 insertion(+), 16 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
>> index 96c923b..62d9214 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
>> @@ -173,7 +173,7 @@ static bool rtl92cu_get_btc_status(void)
>> .rx_urb_num = RTL92C_NUM_RX_URBS,
>> .rx_max_size = RTL92C_SIZE_MAX_RX_BUFFER,
>> .usb_rx_hdl = rtl8192cu_rx_hdl,
>> - .usb_rx_segregate_hdl = NULL, /* rtl8192c_rx_segregate_hdl; */
>> + .usb_rx_segregate_hdl = NULL,
>> /* tx */
>> .usb_tx_cleanup = rtl8192c_tx_cleanup,
>> .usb_tx_post_hdl = rtl8192c_tx_post_hdl,
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
>> index 41422e4..25a081c 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
>> @@ -436,13 +436,6 @@ void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb)
>> _rtl_rx_process(hw, skb);
>> }
>>
>> -void rtl8192c_rx_segregate_hdl(
>> - struct ieee80211_hw *hw,
>> - struct sk_buff *skb,
>> - struct sk_buff_head *skb_list)
>> -{
>> -}
>> -
>> /*----------------------------------------------------------------------
>> *
>> * Tx handler
>> @@ -675,8 +668,3 @@ void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
>> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD, "H2C Tx Cmd Content",
>> pdesc, RTL_TX_DESC_SIZE);
>> }
>> -
>> -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
>> -{
>> - return true;
>> -}
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
>> index 487eec8..15a66c5 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h
>> @@ -385,8 +385,6 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw,
>> struct ieee80211_rx_status *rx_status,
>> u8 *p_desc, struct sk_buff *skb);
>> void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb);
>> -void rtl8192c_rx_segregate_hdl(struct ieee80211_hw *, struct sk_buff *,
>> - struct sk_buff_head *);
>> void rtl8192c_tx_cleanup(struct ieee80211_hw *hw, struct sk_buff *skb);
>> int rtl8192c_tx_post_hdl(struct ieee80211_hw *hw, struct urb *urb,
>> struct sk_buff *skb);
>> @@ -404,6 +402,5 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 * pDesc,
>> void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw,
>> u8 *pdesc, bool b_firstseg,
>> bool b_lastseg, struct sk_buff *skb);
>> -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb);
>>
>> #endif
>> --
>> 1.9.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: rtlwifi: Remove unused dummy function
2017-06-28 12:32 [PATCH] rtlwifi: Remove unused dummy function Souptick Joarder
2017-07-04 12:22 ` Souptick Joarder
@ 2017-07-28 15:42 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2017-07-28 15:42 UTC (permalink / raw)
To: Souptick Joarder; +Cc: Larry.Finger, chaoming_li, linux-wireless
Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Removing unused dummy function
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
4de95fc5fa11 rtlwifi: Remove unused dummy function
--
https://patchwork.kernel.org/patch/9814165/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-28 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 12:32 [PATCH] rtlwifi: Remove unused dummy function Souptick Joarder
2017-07-04 12:22 ` Souptick Joarder
2017-07-04 13:12 ` Kalle Valo
2017-07-04 16:27 ` Larry Finger
2017-07-28 15:42 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).