* [PATCH] dt-bindings: mt76: add active-low property to led
@ 2023-02-07 10:25 Frank Wunderlich
2023-02-07 10:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2023-02-07 10:25 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
LEDs can be in low-active mode, so add dt property for it.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index f0c78f994491..212508672979 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -112,6 +112,11 @@ properties:
$ref: /schemas/leds/common.yaml#
additionalProperties: false
properties:
+ led-active-low:
+ description:
+ LED is enabled with ground signal.
+ type: boolean
+
led-sources:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mt76: add active-low property to led
2023-02-07 10:25 [PATCH] dt-bindings: mt76: add active-low property to led Frank Wunderlich
@ 2023-02-07 10:40 ` Krzysztof Kozlowski
2023-02-07 12:12 ` Aw: " Frank Wunderlich
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 10:40 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, linux-wireless, netdev,
devicetree, linux-arm-kernel, linux-kernel
On 07/02/2023 11:25, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> LEDs can be in low-active mode, so add dt property for it.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index f0c78f994491..212508672979 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -112,6 +112,11 @@ properties:
> $ref: /schemas/leds/common.yaml#
> additionalProperties: false
> properties:
> + led-active-low:
> + description:
> + LED is enabled with ground signal.
What does it mean? You set voltage of regulator to 0? Or you set GPIO as
0? If the latter, it's not the property of LED...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Aw: Re: [PATCH] dt-bindings: mt76: add active-low property to led
2023-02-07 10:40 ` Krzysztof Kozlowski
@ 2023-02-07 12:12 ` Frank Wunderlich
2023-02-07 12:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2023-02-07 12:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Frank Wunderlich, linux-mediatek, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
linux-wireless, netdev, devicetree, linux-arm-kernel,
linux-kernel
> Gesendet: Dienstag, 07. Februar 2023 um 11:40 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> On 07/02/2023 11:25, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > LEDs can be in low-active mode, so add dt property for it.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index f0c78f994491..212508672979 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -112,6 +112,11 @@ properties:
> > $ref: /schemas/leds/common.yaml#
> > additionalProperties: false
> > properties:
> > + led-active-low:
> > + description:
> > + LED is enabled with ground signal.
>
> What does it mean? You set voltage of regulator to 0? Or you set GPIO as
> 0? If the latter, it's not the property of LED...
basicly it is a gpio-led mapped into the mt76 driver, but not passing gpio itself in this property (like gpio-led does).
This gpio is set to 0 signal (gnd) to let the led go on ;) so imho it is a led-property, but below the wifi-node as
the trigger comes from mt76 hardware, not an external (soc) gpio controller.
mt76 driver supports it already like i post change here:
https://patchwork.kernel.org/project/linux-mediatek/patch/20230205174833.107050-1-linux@fw-web.de/
only needed the binding for it.
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Aw: Re: [PATCH] dt-bindings: mt76: add active-low property to led
2023-02-07 12:12 ` Aw: " Frank Wunderlich
@ 2023-02-07 12:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 12:26 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Frank Wunderlich, linux-mediatek, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang, Kalle Valo,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
linux-wireless, netdev, devicetree, linux-arm-kernel,
linux-kernel
On 07/02/2023 13:12, Frank Wunderlich wrote:
>> Gesendet: Dienstag, 07. Februar 2023 um 11:40 Uhr
>> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
>> On 07/02/2023 11:25, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> LEDs can be in low-active mode, so add dt property for it.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>> ---
>>> .../devicetree/bindings/net/wireless/mediatek,mt76.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>>> index f0c78f994491..212508672979 100644
>>> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>>> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
>>> @@ -112,6 +112,11 @@ properties:
>>> $ref: /schemas/leds/common.yaml#
>>> additionalProperties: false
>>> properties:
>>> + led-active-low:
>>> + description:
>>> + LED is enabled with ground signal.
>>
>> What does it mean? You set voltage of regulator to 0? Or you set GPIO as
>> 0? If the latter, it's not the property of LED...
>
> basicly it is a gpio-led mapped into the mt76 driver, but not passing gpio itself in this property (like gpio-led does).
> This gpio is set to 0 signal (gnd) to let the led go on ;) so imho it is a led-property, but below the wifi-node as
> the trigger comes from mt76 hardware, not an external (soc) gpio controller.
>
> mt76 driver supports it already like i post change here:
>
If the driver supports it already and it was never documented, please
state it. Your commit says you add a new property.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-07 12:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 10:25 [PATCH] dt-bindings: mt76: add active-low property to led Frank Wunderlich
2023-02-07 10:40 ` Krzysztof Kozlowski
2023-02-07 12:12 ` Aw: " Frank Wunderlich
2023-02-07 12:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).