* [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant
@ 2024-03-05 19:55 Ricardo B. Marliere
2024-03-06 8:18 ` Miquel Raynal
2024-03-06 21:18 ` Stefan Schmidt
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-03-05 19:55 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, Miquel Raynal, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-wpan, netdev, linux-kernel, Greg Kroah-Hartman,
Ricardo B. Marliere
Since commit 43a7206b0963 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the wpan_phy_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
net/ieee802154/sysfs.c | 2 +-
net/ieee802154/sysfs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ieee802154/sysfs.c b/net/ieee802154/sysfs.c
index d2903933805c..6708160ebf9f 100644
--- a/net/ieee802154/sysfs.c
+++ b/net/ieee802154/sysfs.c
@@ -93,7 +93,7 @@ static SIMPLE_DEV_PM_OPS(wpan_phy_pm_ops, wpan_phy_suspend, wpan_phy_resume);
#define WPAN_PHY_PM_OPS NULL
#endif
-struct class wpan_phy_class = {
+const struct class wpan_phy_class = {
.name = "ieee802154",
.dev_release = wpan_phy_release,
.dev_groups = pmib_groups,
diff --git a/net/ieee802154/sysfs.h b/net/ieee802154/sysfs.h
index 337545b639e9..69961e166257 100644
--- a/net/ieee802154/sysfs.h
+++ b/net/ieee802154/sysfs.h
@@ -5,6 +5,6 @@
int wpan_phy_sysfs_init(void);
void wpan_phy_sysfs_exit(void);
-extern struct class wpan_phy_class;
+extern const struct class wpan_phy_class;
#endif /* __IEEE802154_SYSFS_H */
---
base-commit: 42683294cc0a9ba010de5d978fd23fd1e778b192
change-id: 20240305-class_cleanup-wpan-f299173274b0
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant
2024-03-05 19:55 [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant Ricardo B. Marliere
@ 2024-03-06 8:18 ` Miquel Raynal
2024-03-06 21:18 ` Stefan Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2024-03-06 8:18 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Alexander Aring, Stefan Schmidt, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wpan, netdev, linux-kernel,
Greg Kroah-Hartman
Hi Ricardo,
ricardo@marliere.net wrote on Tue, 05 Mar 2024 16:55:24 -0300:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the wpan_phy_class structure to be declared at build time
> placing it into read-only memory, instead of having to be dynamically
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant
2024-03-05 19:55 [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant Ricardo B. Marliere
2024-03-06 8:18 ` Miquel Raynal
@ 2024-03-06 21:18 ` Stefan Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Schmidt @ 2024-03-06 21:18 UTC (permalink / raw)
To: Ricardo B. Marliere, Alexander Aring, Miquel Raynal,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-wpan, netdev, linux-kernel, Greg Kroah-Hartman
Hello.
On 05.03.24 20:55, Ricardo B. Marliere wrote:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the wpan_phy_class structure to be declared at build time
> placing it into read-only memory, instead of having to be dynamically
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-06 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-05 19:55 [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant Ricardo B. Marliere
2024-03-06 8:18 ` Miquel Raynal
2024-03-06 21:18 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).