* [PATCH] net: ieee802154: remove redundant assignment to rc
@ 2019-08-13 14:28 Colin King
2019-08-13 23:28 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-08-13 14:28 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, David S . Miller, linux-wpan, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable rc is initialized to a value that is never read and it is
re-assigned later. The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ieee802154/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index dacbd58e1799..badc5cfe4dc6 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -1092,7 +1092,7 @@ static struct packet_type ieee802154_packet_type = {
static int __init af_ieee802154_init(void)
{
- int rc = -EINVAL;
+ int rc;
rc = proto_register(&ieee802154_raw_prot, 1);
if (rc)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ieee802154: remove redundant assignment to rc
2019-08-13 14:28 [PATCH] net: ieee802154: remove redundant assignment to rc Colin King
@ 2019-08-13 23:28 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2019-08-13 23:28 UTC (permalink / raw)
To: Colin King, Alexander Aring, David S . Miller, linux-wpan, netdev
Cc: kernel-janitors, linux-kernel
Hello.
On 13.08.19 16:28, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable rc is initialized to a value that is never read and it is
> re-assigned later. The initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/ieee802154/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
> index dacbd58e1799..badc5cfe4dc6 100644
> --- a/net/ieee802154/socket.c
> +++ b/net/ieee802154/socket.c
> @@ -1092,7 +1092,7 @@ static struct packet_type ieee802154_packet_type = {
>
> static int __init af_ieee802154_init(void)
> {
> - int rc = -EINVAL;
> + int rc;
>
> rc = proto_register(&ieee802154_raw_prot, 1);
> if (rc)
>
This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-13 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 14:28 [PATCH] net: ieee802154: remove redundant assignment to rc Colin King
2019-08-13 23:28 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).