From: Jakub Kicinski <kuba@kernel.org>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Alexander Aring <alex.aring@gmail.com>,
alex.bluesman.smirnov@gmail.com, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net 05/16] nl802154: add missing attribute validation for dev_type
Date: Tue, 3 Mar 2020 09:55:48 -0800 [thread overview]
Message-ID: <20200303095548.047a2c9b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <3c27dd0a-ff54-681b-b97c-98cd9d096b41@datenfreihafen.org>
On Tue, 3 Mar 2020 16:39:55 +0100 Stefan Schmidt wrote:
> On 03.03.20 06:05, Jakub Kicinski wrote:
> > Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE
> > to the netlink policy.
> >
> > Fixes: 90c049b2c6ae ("ieee802154: interface type to be added")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c
> > index 824e7e84014c..0672b2f01586 100644
> > --- a/net/ieee802154/nl_policy.c
> > +++ b/net/ieee802154/nl_policy.c
> > @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = {
> > [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, },
> > [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, },
> > [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, },
> > + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, },
> > [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, },
> > [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, },
> > [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, },
> >
>
> The reason to split this off from the patch before is to have the Fixes
> tag differently to point to its origin?
Yup, plus they should hopefully be in chronological order to avoid
conflicts :)
> Might be a bit to much work for this little subsystem, but you did it
> already, so:
>
> Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
Thanks!
prev parent reply other threads:[~2020-03-03 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200303050526.4088735-1-kuba@kernel.org>
2020-03-03 5:05 ` [PATCH net 04/16] nl802154: add missing attribute validation Jakub Kicinski
2020-03-03 15:38 ` Stefan Schmidt
2020-03-03 5:05 ` [PATCH net 05/16] nl802154: add missing attribute validation for dev_type Jakub Kicinski
2020-03-03 15:39 ` Stefan Schmidt
2020-03-03 17:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303095548.047a2c9b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).