* [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands
@ 2023-02-13 17:47 Miquel Raynal
2023-11-28 11:27 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2023-02-13 17:47 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, linux-wpan
Cc: David Girault, Romuald Despres, Frederic Blain, Nicolas Schodet,
Guilhem Imberton, Thomas Petazzoni, Miquel Raynal
Allow running:
iwpan phy <phy> scan trigger ...
iwpan phy <phy> scan abort ...
Aside with the existing:
iwpan dev <dev> scan trigger ...
iwpan dev <dev> scan abort ...
This change does not apply easily to the TOPLEVEL(scan) command, so we
keep this one more constrained for simplicity.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
src/scan.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/scan.c b/src/scan.c
index e92702d..8bc21ca 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -541,11 +541,15 @@ TOPLEVEL(scan, "type <type> [page <page>] [channels <bitfield>] [duration <durat
SCAN_TYPES);
COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_NETDEV, scan_abort_handler,
"Abort ongoing scanning on this virtual interface");
+COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_PHY, scan_abort_handler, NULL);
COMMAND(scan, trigger,
"type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
NL802154_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, scan_trigger_handler,
"Launch scanning on this virtual interface with the given configuration.\n"
SCAN_TYPES);
+COMMAND(scan, trigger,
+ "type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
+ NL802154_CMD_TRIGGER_SCAN, 0, CIB_PHY, scan_trigger_handler, NULL);
SECTION(beacons);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands
2023-02-13 17:47 [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands Miquel Raynal
@ 2023-11-28 11:27 ` Miquel Raynal
2023-12-07 20:55 ` Stefan Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2023-11-28 11:27 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, linux-wpan
Cc: David Girault, Romuald Despres, Frederic Blain, Nicolas Schodet,
Guilhem Imberton, Thomas Petazzoni
Hi Stefan,
miquel.raynal@bootlin.com wrote on Mon, 13 Feb 2023 18:47:03 +0100:
> Allow running:
> iwpan phy <phy> scan trigger ...
> iwpan phy <phy> scan abort ...
>
> Aside with the existing:
> iwpan dev <dev> scan trigger ...
> iwpan dev <dev> scan abort ...
>
> This change does not apply easily to the TOPLEVEL(scan) command, so we
> keep this one more constrained for simplicity.
I believe this patch felt into the cracks, I think I remember it came
from a request from Alex, maybe you will want to consider it for merge
despite its "age"? Or maybe I missed some feedback in the SPAMS /o\
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> src/scan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/scan.c b/src/scan.c
> index e92702d..8bc21ca 100644
> --- a/src/scan.c
> +++ b/src/scan.c
> @@ -541,11 +541,15 @@ TOPLEVEL(scan, "type <type> [page <page>] [channels <bitfield>] [duration <durat
> SCAN_TYPES);
> COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_NETDEV, scan_abort_handler,
> "Abort ongoing scanning on this virtual interface");
> +COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_PHY, scan_abort_handler, NULL);
> COMMAND(scan, trigger,
> "type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
> NL802154_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, scan_trigger_handler,
> "Launch scanning on this virtual interface with the given configuration.\n"
> SCAN_TYPES);
> +COMMAND(scan, trigger,
> + "type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
> + NL802154_CMD_TRIGGER_SCAN, 0, CIB_PHY, scan_trigger_handler, NULL);
>
> SECTION(beacons);
>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands
2023-11-28 11:27 ` Miquel Raynal
@ 2023-12-07 20:55 ` Stefan Schmidt
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Schmidt @ 2023-12-07 20:55 UTC (permalink / raw)
To: Miquel Raynal, Alexander Aring, linux-wpan
Cc: David Girault, Romuald Despres, Frederic Blain, Nicolas Schodet,
Guilhem Imberton, Thomas Petazzoni
Hello.
On 28.11.23 12:27, Miquel Raynal wrote:
> Hi Stefan,
>
> miquel.raynal@bootlin.com wrote on Mon, 13 Feb 2023 18:47:03 +0100:
>
>> Allow running:
>> iwpan phy <phy> scan trigger ...
>> iwpan phy <phy> scan abort ...
>>
>> Aside with the existing:
>> iwpan dev <dev> scan trigger ...
>> iwpan dev <dev> scan abort ...
>>
>> This change does not apply easily to the TOPLEVEL(scan) command, so we
>> keep this one more constrained for simplicity.
>
> I believe this patch felt into the cracks, I think I remember it came
> from a request from Alex, maybe you will want to consider it for merge
> despite its "age"? Or maybe I missed some feedback in the SPAMS /o\
Nope, just fallen through the cracks. Applied now:
https://github.com/linux-wpan/wpan-tools/commit/3036dc0533abd6a89d5d0df0f3d9013aa294cbb3
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-07 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 17:47 [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands Miquel Raynal
2023-11-28 11:27 ` Miquel Raynal
2023-12-07 20:55 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).