* [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
[not found] <20240108181610.2697017-1-leitao@debian.org>
@ 2024-01-08 18:16 ` Breno Leitao
2024-01-09 7:25 ` Stefan Schmidt
2024-01-08 18:16 ` [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN Breno Leitao
1 sibling, 1 reply; 9+ messages in thread
From: Breno Leitao @ 2024-01-08 18:16 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, Alexander Aring, Stefan Schmidt,
Miquel Raynal
Cc: netdev, open list:IEEE 802.15.4 SUBSYSTEM, open list
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to ieee802154 modules.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
net/ieee802154/6lowpan/core.c | 1 +
net/ieee802154/socket.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 2c087b7f17c5..b88f6a96d961 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
module_init(lowpan_init_module);
module_exit(lowpan_cleanup_module);
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");
MODULE_LICENSE("GPL");
MODULE_ALIAS_RTNL_LINK("lowpan");
diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index 00302e8b9615..db8df6e26159 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init);
module_exit(af_ieee802154_remove);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("IEEE802154.4 socket interface");
MODULE_ALIAS_NETPROTO(PF_IEEE802154);
--
2.39.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
[not found] <20240108181610.2697017-1-leitao@debian.org>
2024-01-08 18:16 ` [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
@ 2024-01-08 18:16 ` Breno Leitao
2024-01-10 1:04 ` Alexander Aring
1 sibling, 1 reply; 9+ messages in thread
From: Breno Leitao @ 2024-01-08 18:16 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, Alexander Aring
Cc: netdev, open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to IPv6 over Low power Wireless Personal Area Network.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
net/6lowpan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
index 7b3341cef926..80d83151ef29 100644
--- a/net/6lowpan/core.c
+++ b/net/6lowpan/core.c
@@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
module_init(lowpan_module_init);
module_exit(lowpan_module_exit);
-
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
2024-01-08 18:16 ` [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
@ 2024-01-09 7:25 ` Stefan Schmidt
2024-01-09 14:29 ` Breno Leitao
2024-01-24 16:48 ` Miquel Raynal
0 siblings, 2 replies; 9+ messages in thread
From: Stefan Schmidt @ 2024-01-09 7:25 UTC (permalink / raw)
To: Breno Leitao, davem, edumazet, kuba, pabeni, Alexander Aring,
Miquel Raynal
Cc: netdev, open list:IEEE 802.15.4 SUBSYSTEM, open list
Hello.
On 08.01.24 19:16, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to ieee802154 modules.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/ieee802154/6lowpan/core.c | 1 +
> net/ieee802154/socket.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index 2c087b7f17c5..b88f6a96d961 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
>
> module_init(lowpan_init_module);
> module_exit(lowpan_cleanup_module);
> +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");
If we want to nitpick you could write it as IEEE 802.15.4.
> MODULE_LICENSE("GPL");
> MODULE_ALIAS_RTNL_LINK("lowpan");
> diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
> index 00302e8b9615..db8df6e26159 100644
> --- a/net/ieee802154/socket.c
> +++ b/net/ieee802154/socket.c
> @@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init);
> module_exit(af_ieee802154_remove);
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("IEEE802154.4 socket interface");
> MODULE_ALIAS_NETPROTO(PF_IEEE802154);
Same here.
Besides this:
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
2024-01-09 7:25 ` Stefan Schmidt
@ 2024-01-09 14:29 ` Breno Leitao
2024-01-24 16:48 ` Miquel Raynal
1 sibling, 0 replies; 9+ messages in thread
From: Breno Leitao @ 2024-01-09 14:29 UTC (permalink / raw)
To: Stefan Schmidt
Cc: davem, edumazet, kuba, pabeni, Alexander Aring, Miquel Raynal,
netdev, open list:IEEE 802.15.4 SUBSYSTEM, open list
On Tue, Jan 09, 2024 at 08:25:21AM +0100, Stefan Schmidt wrote:
> Hello.
>
> On 08.01.24 19:16, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to ieee802154 modules.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > net/ieee802154/6lowpan/core.c | 1 +
> > net/ieee802154/socket.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> > index 2c087b7f17c5..b88f6a96d961 100644
> > --- a/net/ieee802154/6lowpan/core.c
> > +++ b/net/ieee802154/6lowpan/core.c
> > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
> > module_init(lowpan_init_module);
> > module_exit(lowpan_cleanup_module);
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");
>
> If we want to nitpick you could write it as IEEE 802.15.4.
Thanks. I will update.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
2024-01-08 18:16 ` [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN Breno Leitao
@ 2024-01-10 1:04 ` Alexander Aring
2024-01-10 1:05 ` Alexander Aring
2024-01-10 9:19 ` Breno Leitao
0 siblings, 2 replies; 9+ messages in thread
From: Alexander Aring @ 2024-01-10 1:04 UTC (permalink / raw)
To: Breno Leitao
Cc: davem, edumazet, kuba, pabeni, Alexander Aring, netdev,
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list
Hi,
On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
>
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to IPv6 over Low power Wireless Personal Area Network.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> net/6lowpan/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> index 7b3341cef926..80d83151ef29 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
>
> module_init(lowpan_module_init);
> module_exit(lowpan_module_exit);
> -
> +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
Here is a nitpick as well. The correct acronym [0] is "IPv6 over
Low-Power Wireless Personal Area Network", otherwise it is okay.
Acked-by: Alexander Aring <aahringo@redhat.com>
- Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
2024-01-10 1:04 ` Alexander Aring
@ 2024-01-10 1:05 ` Alexander Aring
2024-01-10 9:19 ` Breno Leitao
1 sibling, 0 replies; 9+ messages in thread
From: Alexander Aring @ 2024-01-10 1:05 UTC (permalink / raw)
To: Breno Leitao
Cc: davem, edumazet, kuba, pabeni, Alexander Aring, netdev,
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list
Hi,
On Tue, Jan 9, 2024 at 8:04 PM Alexander Aring <aahringo@redhat.com> wrote:
>
> Hi,
>
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > net/6lowpan/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> > module_init(lowpan_module_init);
> > module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
>
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.
>
> Acked-by: Alexander Aring <aahringo@redhat.com>
>
> - Alex
[0] https://datatracker.ietf.org/wg/6lowpan/about/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN
2024-01-10 1:04 ` Alexander Aring
2024-01-10 1:05 ` Alexander Aring
@ 2024-01-10 9:19 ` Breno Leitao
1 sibling, 0 replies; 9+ messages in thread
From: Breno Leitao @ 2024-01-10 9:19 UTC (permalink / raw)
To: Alexander Aring
Cc: davem, edumazet, kuba, pabeni, Alexander Aring, netdev,
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list:6LOWPAN GENERIC (BTLE/IEEE 802.15.4),
open list
On Tue, Jan 09, 2024 at 08:04:47PM -0500, Alexander Aring wrote:
> Hi,
>
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > net/6lowpan/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> > module_init(lowpan_module_init);
> > module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
>
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.
Thanks. I will update.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
2024-01-09 7:25 ` Stefan Schmidt
2024-01-09 14:29 ` Breno Leitao
@ 2024-01-24 16:48 ` Miquel Raynal
2024-01-25 10:00 ` Breno Leitao
1 sibling, 1 reply; 9+ messages in thread
From: Miquel Raynal @ 2024-01-24 16:48 UTC (permalink / raw)
To: Stefan Schmidt
Cc: Breno Leitao, davem, edumazet, kuba, pabeni, Alexander Aring,
netdev, open list:IEEE 802.15.4 SUBSYSTEM, open list
Hi,
stefan@datenfreihafen.org wrote on Tue, 9 Jan 2024 08:25:21 +0100:
> Hello.
>
> On 08.01.24 19:16, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to ieee802154 modules.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > net/ieee802154/6lowpan/core.c | 1 +
> > net/ieee802154/socket.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> > index 2c087b7f17c5..b88f6a96d961 100644
> > --- a/net/ieee802154/6lowpan/core.c
> > +++ b/net/ieee802154/6lowpan/core.c
> > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
> > > module_init(lowpan_init_module);
> > module_exit(lowpan_cleanup_module);
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");
>
> If we want to nitpick you could write it as IEEE 802.15.4.
Also agreed, can you please post an update?
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
2024-01-24 16:48 ` Miquel Raynal
@ 2024-01-25 10:00 ` Breno Leitao
0 siblings, 0 replies; 9+ messages in thread
From: Breno Leitao @ 2024-01-25 10:00 UTC (permalink / raw)
To: Miquel Raynal
Cc: Stefan Schmidt, davem, edumazet, kuba, pabeni, Alexander Aring,
netdev, open list:IEEE 802.15.4 SUBSYSTEM, open list
Hello Miquèl,
On Wed, Jan 24, 2024 at 05:48:02PM +0100, Miquel Raynal wrote:
> Hi,
>
> stefan@datenfreihafen.org wrote on Tue, 9 Jan 2024 08:25:21 +0100:
>
> > Hello.
> >
> > On 08.01.24 19:16, Breno Leitao wrote:
> > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > > Add descriptions to ieee802154 modules.
> > >
> > > Signed-off-by: Breno Leitao <leitao@debian.org>
> > > ---
> > > net/ieee802154/6lowpan/core.c | 1 +
> > > net/ieee802154/socket.c | 1 +
> > > 2 files changed, 2 insertions(+)
> > >
> > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> > > index 2c087b7f17c5..b88f6a96d961 100644
> > > --- a/net/ieee802154/6lowpan/core.c
> > > +++ b/net/ieee802154/6lowpan/core.c
> > > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
> > > > module_init(lowpan_init_module);
> > > module_exit(lowpan_cleanup_module);
> > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");
> >
> > If we want to nitpick you could write it as IEEE 802.15.4.
>
> Also agreed, can you please post an update?
Sure. I will send it soon, since I am splitting the patches in a set of
10. According to the maintainer's request:
https://lore.kernel.org/all/20240122105708.52d33fa0@kernel.org/
For now, I am focusing on Ethernet drivers.
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-01-25 10:00 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240108181610.2697017-1-leitao@debian.org>
2024-01-08 18:16 ` [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
2024-01-09 7:25 ` Stefan Schmidt
2024-01-09 14:29 ` Breno Leitao
2024-01-24 16:48 ` Miquel Raynal
2024-01-25 10:00 ` Breno Leitao
2024-01-08 18:16 ` [PATCH net-next 07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN Breno Leitao
2024-01-10 1:04 ` Alexander Aring
2024-01-10 1:05 ` Alexander Aring
2024-01-10 9:19 ` Breno Leitao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).