Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ieee802154/adf7242: check status of adf7242_read_reg
@ 2020-08-02 14:23 trix
  2020-08-03  6:20 ` Hennerich, Michael
  2020-08-03 18:27 ` Stefan Schmidt
  0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-08-02 14:23 UTC (permalink / raw)
  To: michael.hennerich, alex.aring, stefan, davem, kuba, marcel
  Cc: linux-wpan, netdev, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

Clang static analysis reports this error

adf7242.c:887:6: warning: Assigned value is garbage or undefined
        len = len_u8;
            ^ ~~~~~~

len_u8 is set in
       adf7242_read_reg(lp, 0, &len_u8);

When this call fails, len_u8 is not set.

So check the return code.

Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ieee802154/adf7242.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index c11f32f644db..7db9cbd0f5de 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp)
 	int ret;
 	u8 lqi, len_u8, *data;
 
-	adf7242_read_reg(lp, 0, &len_u8);
+	ret = adf7242_read_reg(lp, 0, &len_u8);
+	if (ret)
+		return ret;
 
 	len = len_u8;
 
-- 
2.18.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg
  2020-08-02 14:23 [PATCH] ieee802154/adf7242: check status of adf7242_read_reg trix
@ 2020-08-03  6:20 ` Hennerich, Michael
  2020-08-03 18:27 ` Stefan Schmidt
  1 sibling, 0 replies; 3+ messages in thread
From: Hennerich, Michael @ 2020-08-03  6:20 UTC (permalink / raw)
  To: trix, alex.aring, stefan, davem, kuba, marcel
  Cc: linux-wpan, netdev, linux-kernel



> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Sonntag, 2. August 2020 16:24
> To: Hennerich, Michael <Michael.Hennerich@analog.com>;
> alex.aring@gmail.com; stefan@datenfreihafen.org; davem@davemloft.net;
> kuba@kernel.org; marcel@holtmann.org
> Cc: linux-wpan@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg
> 
> 
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this error
> 
> adf7242.c:887:6: warning: Assigned value is garbage or undefined
>         len = len_u8;
>             ^ ~~~~~~
> 
> len_u8 is set in
>        adf7242_read_reg(lp, 0, &len_u8);
> 
> When this call fails, len_u8 is not set.
> 
> So check the return code.
> 
> Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC
> IEEE802154")
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/net/ieee802154/adf7242.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/adf7242.c
> b/drivers/net/ieee802154/adf7242.c
> index c11f32f644db..7db9cbd0f5de 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp)
>  	int ret;
>  	u8 lqi, len_u8, *data;
> 
> -	adf7242_read_reg(lp, 0, &len_u8);
> +	ret = adf7242_read_reg(lp, 0, &len_u8);
> +	if (ret)
> +		return ret;
> 
>  	len = len_u8;
> 
> --
> 2.18.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg
  2020-08-02 14:23 [PATCH] ieee802154/adf7242: check status of adf7242_read_reg trix
  2020-08-03  6:20 ` Hennerich, Michael
@ 2020-08-03 18:27 ` Stefan Schmidt
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Schmidt @ 2020-08-03 18:27 UTC (permalink / raw)
  To: trix, michael.hennerich, alex.aring, davem, kuba, marcel
  Cc: linux-wpan, netdev, linux-kernel

Hello.

On 02.08.20 16:23, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this error
> 
> adf7242.c:887:6: warning: Assigned value is garbage or undefined
>          len = len_u8;
>              ^ ~~~~~~
> 
> len_u8 is set in
>         adf7242_read_reg(lp, 0, &len_u8);
> 
> When this call fails, len_u8 is not set.
> 
> So check the return code.
> 
> Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/net/ieee802154/adf7242.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
> index c11f32f644db..7db9cbd0f5de 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp)
>   	int ret;
>   	u8 lqi, len_u8, *data;
>   
> -	adf7242_read_reg(lp, 0, &len_u8);
> +	ret = adf7242_read_reg(lp, 0, &len_u8);
> +	if (ret)
> +		return ret;
>   
>   	len = len_u8;
>   
> 


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 14:23 [PATCH] ieee802154/adf7242: check status of adf7242_read_reg trix
2020-08-03  6:20 ` Hennerich, Michael
2020-08-03 18:27 ` Stefan Schmidt

Linux-WPAN Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
		linux-wpan@vger.kernel.org
	public-inbox-index linux-wpan

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git