linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache
@ 2024-02-02  6:46 Bo Liu
  2024-02-26 20:50 ` Stefan Schmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Bo Liu @ 2024-02-02  6:46 UTC (permalink / raw)
  To: alex.aring, miquel.raynal, davem, edumazet, kuba, pabeni
  Cc: linux-wpan, netdev, linux-kernel, Bo Liu

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Bo Liu <liubo03@inspur.com>
---
 drivers/net/ieee802154/mrf24j40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ee4cfbf2c5cc..d3f42efc5d1a 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
 	.pad_bits = 1,
 	.write_flag_mask = MRF24J40_SHORT_WRITE,
 	.read_flag_mask = MRF24J40_SHORT_READ,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.max_register = MRF24J40_SHORT_NUMREGS,
 	.writeable_reg = mrf24j40_short_reg_writeable,
 	.readable_reg = mrf24j40_short_reg_readable,
@@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
 	.pad_bits = 5,
 	.write_flag_mask = MRF24J40_LONG_ACCESS,
 	.read_flag_mask = MRF24J40_LONG_ACCESS,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.max_register = MRF24J40_LONG_NUMREGS,
 	.writeable_reg = mrf24j40_long_reg_writeable,
 	.readable_reg = mrf24j40_long_reg_readable,
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache
  2024-02-02  6:46 [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache Bo Liu
@ 2024-02-26 20:50 ` Stefan Schmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2024-02-26 20:50 UTC (permalink / raw)
  To: Bo Liu, alex.aring, miquel.raynal, davem, edumazet, kuba, pabeni
  Cc: linux-wpan, netdev, linux-kernel

Hello,

On 02.02.24 07:46, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee4cfbf2c5cc..d3f42efc5d1a 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -388,7 +388,7 @@ static const struct regmap_config mrf24j40_short_regmap = {
>   	.pad_bits = 1,
>   	.write_flag_mask = MRF24J40_SHORT_WRITE,
>   	.read_flag_mask = MRF24J40_SHORT_READ,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_SHORT_NUMREGS,
>   	.writeable_reg = mrf24j40_short_reg_writeable,
>   	.readable_reg = mrf24j40_short_reg_readable,
> @@ -495,7 +495,7 @@ static const struct regmap_config mrf24j40_long_regmap = {
>   	.pad_bits = 5,
>   	.write_flag_mask = MRF24J40_LONG_ACCESS,
>   	.read_flag_mask = MRF24J40_LONG_ACCESS,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.max_register = MRF24J40_LONG_NUMREGS,
>   	.writeable_reg = mrf24j40_long_reg_writeable,
>   	.readable_reg = mrf24j40_long_reg_readable,

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-26 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-02  6:46 [PATCH] net: ieee802154: mrf24j40: convert to use maple tree register cache Bo Liu
2024-02-26 20:50 ` Stefan Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).