* [PATCH] x_25: Adding a null pointer dereference check to the x25_accept() function
@ 2024-03-13 13:22 Mikhail Lobanov
2024-03-13 14:13 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Mikhail Lobanov @ 2024-03-13 13:22 UTC (permalink / raw)
To: Martin Schiller
Cc: Mikhail Lobanov, David S. Miller, Eric Dumazet, Jakub Kicinski,
linux-x25, linux-kernel
To avoid the problem of dereferencing the null pointer in the x25_accept()
function, you need to add an additional check that the pointer skb is
not equal to NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Mikhail Lobanov <m.lobanov@rosalinux.ru>
---
net/x25/af_x25.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index f7a7c7798c3b..91bc5994cef6 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -896,7 +896,7 @@ static int x25_accept(struct socket *sock, struct socket *newsock, int flags,
goto out2;
skb = skb_dequeue(&sk->sk_receive_queue);
rc = -EINVAL;
- if (!skb->sk)
+ if (!skb || !skb->sk)
goto out2;
newsk = skb->sk;
sock_graft(newsk, newsock);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x_25: Adding a null pointer dereference check to the x25_accept() function
2024-03-13 13:22 [PATCH] x_25: Adding a null pointer dereference check to the x25_accept() function Mikhail Lobanov
@ 2024-03-13 14:13 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2024-03-13 14:13 UTC (permalink / raw)
To: Mikhail Lobanov
Cc: Martin Schiller, David S. Miller, Jakub Kicinski, linux-x25,
linux-kernel
On Wed, Mar 13, 2024 at 2:23 PM Mikhail Lobanov <m.lobanov@rosalinux.ru> wrote:
>
> To avoid the problem of dereferencing the null pointer in the x25_accept()
> function, you need to add an additional check that the pointer skb is
> not equal to NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Mikhail Lobanov <m.lobanov@rosalinux.ru>
> ---
> net/x25/af_x25.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
> index f7a7c7798c3b..91bc5994cef6 100644
> --- a/net/x25/af_x25.c
> +++ b/net/x25/af_x25.c
> @@ -896,7 +896,7 @@ static int x25_accept(struct socket *sock, struct socket *newsock, int flags,
> goto out2;
> skb = skb_dequeue(&sk->sk_receive_queue);
skb can not be NULL at this point, we hold the socket lock.
Otherwise the bug would be in x25_wait_for_data()
> rc = -EINVAL;
> - if (!skb->sk)
> + if (!skb || !skb->sk)
> goto out2;
> newsk = skb->sk;
> sock_graft(newsk, newsock);
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-13 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-13 13:22 [PATCH] x_25: Adding a null pointer dereference check to the x25_accept() function Mikhail Lobanov
2024-03-13 14:13 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).