From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 3/6] xfs: make the assertion message functions take a mount parameter
Date: Sun, 03 Nov 2019 14:24:23 -0800 [thread overview]
Message-ID: <157281986300.4151907.2698280321479729910.stgit@magnolia> (raw)
In-Reply-To: <157281984457.4151907.11281776450827989936.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Make the assfail and asswarn functions take a struct xfs_mount so that
we can start tying debugging and corruption messages to a particular
mount.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_linux.h | 6 +++---
fs/xfs/xfs_message.c | 8 ++++----
fs/xfs/xfs_message.h | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index ca15105681ca..2271db4e8d66 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -223,18 +223,18 @@ int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count,
char *data, unsigned int op);
#define ASSERT_ALWAYS(expr) \
- (likely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
+ (likely(expr) ? (void)0 : assfail(NULL, #expr, __FILE__, __LINE__))
#ifdef DEBUG
#define ASSERT(expr) \
- (likely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
+ (likely(expr) ? (void)0 : assfail(NULL, #expr, __FILE__, __LINE__))
#else /* !DEBUG */
#ifdef XFS_WARN
#define ASSERT(expr) \
- (likely(expr) ? (void)0 : asswarn(#expr, __FILE__, __LINE__))
+ (likely(expr) ? (void)0 : asswarn(NULL, #expr, __FILE__, __LINE__))
#else /* !DEBUG && !XFS_WARN */
diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
index c57e8ad39712..333bc2e14f3f 100644
--- a/fs/xfs/xfs_message.c
+++ b/fs/xfs/xfs_message.c
@@ -86,17 +86,17 @@ xfs_alert_tag(
}
void
-asswarn(char *expr, char *file, int line)
+asswarn(struct xfs_mount *mp, char *expr, char *file, int line)
{
- xfs_warn(NULL, "Assertion failed: %s, file: %s, line: %d",
+ xfs_warn(mp, "Assertion failed: %s, file: %s, line: %d",
expr, file, line);
WARN_ON(1);
}
void
-assfail(char *expr, char *file, int line)
+assfail(struct xfs_mount *mp, char *expr, char *file, int line)
{
- xfs_emerg(NULL, "Assertion failed: %s, file: %s, line: %d",
+ xfs_emerg(mp, "Assertion failed: %s, file: %s, line: %d",
expr, file, line);
if (xfs_globals.bug_on_assert)
BUG();
diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
index 7f040b04b739..28bd6c0777ab 100644
--- a/fs/xfs/xfs_message.h
+++ b/fs/xfs/xfs_message.h
@@ -57,8 +57,8 @@ do { \
#define xfs_debug_ratelimited(dev, fmt, ...) \
xfs_printk_ratelimited(xfs_debug, dev, fmt, ##__VA_ARGS__)
-extern void assfail(char *expr, char *f, int l);
-extern void asswarn(char *expr, char *f, int l);
+extern void assfail(struct xfs_mount *mp, char *expr, char *f, int l);
+extern void asswarn(struct xfs_mount *mp, char *expr, char *f, int l);
extern void xfs_hex_dump(const void *p, int length);
next prev parent reply other threads:[~2019-11-03 22:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 22:24 [PATCH 0/6] xfs: refactor corruption checking and reporting Darrick J. Wong
2019-11-03 22:24 ` [PATCH 1/6] xfs: decrease indenting problems in xfs_dabuf_map Darrick J. Wong
2019-11-05 0:44 ` Christoph Hellwig
2019-11-03 22:24 ` [PATCH 2/6] xfs: add missing assert in xfs_fsmap_owner_from_rmap Darrick J. Wong
2019-11-05 0:44 ` Christoph Hellwig
2019-11-03 22:24 ` Darrick J. Wong [this message]
2019-11-05 0:45 ` [PATCH 3/6] xfs: make the assertion message functions take a mount parameter Christoph Hellwig
2019-11-05 1:08 ` Darrick J. Wong
2019-11-05 1:09 ` [PATCH v2 " Darrick J. Wong
2019-11-05 15:50 ` Christoph Hellwig
2019-11-03 22:24 ` [PATCH 4/6] xfs: add a XFS_CORRUPT_ON macro Darrick J. Wong
2019-11-05 0:48 ` Christoph Hellwig
2019-11-05 0:51 ` Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 4/6] xfs: add a XFS_IS_CORRUPT macro Darrick J. Wong
2019-11-03 22:24 ` [PATCH 5/6] xfs: kill the XFS_WANT_CORRUPT_* macros Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 " Darrick J. Wong
2019-11-03 22:24 ` [PATCH 6/6] xfs: convert open coded corruption check to use XFS_CORRUPT_ON Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 6/6] xfs: convert open coded corruption check to use XFS_IS_CORRUPT Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157281986300.4151907.2698280321479729910.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).