From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] xfs: make the assertion message functions take a mount parameter
Date: Mon, 4 Nov 2019 17:08:11 -0800 [thread overview]
Message-ID: <20191105010811.GV4153244@magnolia> (raw)
In-Reply-To: <20191105004544.GC22247@infradead.org>
On Mon, Nov 04, 2019 at 04:45:44PM -0800, Christoph Hellwig wrote:
> > void
> > -asswarn(char *expr, char *file, int line)
> > +asswarn(struct xfs_mount *mp, char *expr, char *file, int line)
> > {
> > - xfs_warn(NULL, "Assertion failed: %s, file: %s, line: %d",
> > + xfs_warn(mp, "Assertion failed: %s, file: %s, line: %d",
> > expr, file, line);
> > WARN_ON(1);
> > }
> >
> > void
> > -assfail(char *expr, char *file, int line)
> > +assfail(struct xfs_mount *mp, char *expr, char *file, int line)
>
> Might be worth to change it to our usual prototype style while you're
> at it.
>
> > -extern void assfail(char *expr, char *f, int l);
> > -extern void asswarn(char *expr, char *f, int l);
> > +extern void assfail(struct xfs_mount *mp, char *expr, char *f, int l);
> > +extern void asswarn(struct xfs_mount *mp, char *expr, char *f, int l);
>
> And drop the pointless externs?
>
> Otherwise this looks sane to me.
Fixed both of those.
--D
next prev parent reply other threads:[~2019-11-05 1:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 22:24 [PATCH 0/6] xfs: refactor corruption checking and reporting Darrick J. Wong
2019-11-03 22:24 ` [PATCH 1/6] xfs: decrease indenting problems in xfs_dabuf_map Darrick J. Wong
2019-11-05 0:44 ` Christoph Hellwig
2019-11-03 22:24 ` [PATCH 2/6] xfs: add missing assert in xfs_fsmap_owner_from_rmap Darrick J. Wong
2019-11-05 0:44 ` Christoph Hellwig
2019-11-03 22:24 ` [PATCH 3/6] xfs: make the assertion message functions take a mount parameter Darrick J. Wong
2019-11-05 0:45 ` Christoph Hellwig
2019-11-05 1:08 ` Darrick J. Wong [this message]
2019-11-05 1:09 ` [PATCH v2 " Darrick J. Wong
2019-11-05 15:50 ` Christoph Hellwig
2019-11-03 22:24 ` [PATCH 4/6] xfs: add a XFS_CORRUPT_ON macro Darrick J. Wong
2019-11-05 0:48 ` Christoph Hellwig
2019-11-05 0:51 ` Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 4/6] xfs: add a XFS_IS_CORRUPT macro Darrick J. Wong
2019-11-03 22:24 ` [PATCH 5/6] xfs: kill the XFS_WANT_CORRUPT_* macros Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 " Darrick J. Wong
2019-11-03 22:24 ` [PATCH 6/6] xfs: convert open coded corruption check to use XFS_CORRUPT_ON Darrick J. Wong
2019-11-06 4:58 ` [PATCH v2 6/6] xfs: convert open coded corruption check to use XFS_IS_CORRUPT Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105010811.GV4153244@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).