[PATCH 0/1] xfs: random fixes

[PATCH 0/1] xfs: random fixes

[Darrick J. Wong]

Hi all,

Fix a bogus assertion found by Eryu.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This has been lightly tested with fstests.  Enjoy!
Comments and questions are, as always, welcome.

--D

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=random-fixes

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes

[PATCH 1/1] xfs: remove bogus assertion when online repair isn't enabled

[Darrick J. Wong]

From: Darrick J. Wong <darrick.wong@oracle.com>

We don't need to assert on !REPAIR in the stub version of
xrep_calc_ag_resblks that is called when online repair hasn't been
compiled into the kernel because none of the repair code will ever run.

Reported-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/scrub/repair.h |    1 -
 1 file changed, 1 deletion(-)


diff --git a/fs/xfs/scrub/repair.h b/fs/xfs/scrub/repair.h
index 60c61d7052a8..c3422403b169 100644
--- a/fs/xfs/scrub/repair.h
+++ b/fs/xfs/scrub/repair.h
@@ -75,7 +75,6 @@ static inline xfs_extlen_t
 xrep_calc_ag_resblks(
 	struct xfs_scrub	*sc)
 {
-	ASSERT(!(sc->sm->sm_flags & XFS_SCRUB_IFLAG_REPAIR));
 	return 0;
 }
 

Re: [PATCH 1/1] xfs: remove bogus assertion when online repair isn't enabled

[Christoph Hellwig]

On Tue, Jan 07, 2020 at 08:17:59PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> We don't need to assert on !REPAIR in the stub version of
> xrep_calc_ag_resblks that is called when online repair hasn't been
> compiled into the kernel because none of the repair code will ever run.
> 
> Reported-by: Eryu Guan <guaneryu@gmail.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>