* [PATCH] xfs: check all defer ops types
@ 2018-10-26 16:18 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2018-10-26 16:18 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Make sure we have all the defer ops types loaded before proceeding.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_defer.c | 12 ++++++++++++
fs/xfs/libxfs/xfs_defer.h | 1 +
fs/xfs/xfs_super.c | 6 ++++++
3 files changed, 19 insertions(+)
diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c
index e792b167150a..997a7420026b 100644
--- a/fs/xfs/libxfs/xfs_defer.c
+++ b/fs/xfs/libxfs/xfs_defer.c
@@ -547,3 +547,15 @@ xfs_defer_move(
xfs_defer_reset(stp);
}
+
+/* Make sure we filled out all the defer_ops types. */
+bool
+xfs_defer_check_all_present(void)
+{
+ int x;
+
+ for(x = 0; x < XFS_DEFER_OPS_TYPE_MAX; x++)
+ if (defer_op_types[x] == NULL)
+ return false;
+ return true;
+}
diff --git a/fs/xfs/libxfs/xfs_defer.h b/fs/xfs/libxfs/xfs_defer.h
index 2584a5b95b0d..bc7ae7ff3917 100644
--- a/fs/xfs/libxfs/xfs_defer.h
+++ b/fs/xfs/libxfs/xfs_defer.h
@@ -57,5 +57,6 @@ struct xfs_defer_op_type {
};
void xfs_defer_init_op_type(const struct xfs_defer_op_type *type);
+bool xfs_defer_check_all_present(void);
#endif /* __XFS_DEFER_H__ */
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 52ee659f97e2..49d1045fe71e 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -38,6 +38,7 @@
#include "xfs_refcount_item.h"
#include "xfs_bmap_item.h"
#include "xfs_reflink.h"
+#include "xfs_defer.h"
#include <linux/namei.h>
#include <linux/dax.h>
@@ -2220,6 +2221,11 @@ init_xfs_fs(void)
xfs_rmap_update_init_defer_op();
xfs_refcount_update_init_defer_op();
xfs_bmap_update_init_defer_op();
+ if (!xfs_defer_check_all_present()) {
+ printk(KERN_ERR "XFS: missing defer ops types\n");
+ error = -EINVAL;
+ goto out;
+ }
xfs_dir_startup();
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-27 0:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 16:18 [PATCH] xfs: check all defer ops types Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).