* [PATCH] xfs: make xfs_file_remap_range() static
@ 2018-11-15 1:12 Eric Biggers
2018-11-15 5:58 ` Darrick J. Wong
2018-11-15 19:21 ` Allison Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2018-11-15 1:12 UTC (permalink / raw)
To: linux-xfs
From: Eric Biggers <ebiggers@google.com>
xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
static.
This addresses a gcc warning when -Wmissing-prototypes is enabled.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/xfs/xfs_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 53c9ab8fb777f..e47425071e654 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -920,7 +920,7 @@ xfs_file_fallocate(
}
-loff_t
+STATIC loff_t
xfs_file_remap_range(
struct file *file_in,
loff_t pos_in,
--
2.19.1.930.g4563a0d9d0-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: make xfs_file_remap_range() static
2018-11-15 1:12 [PATCH] xfs: make xfs_file_remap_range() static Eric Biggers
@ 2018-11-15 5:58 ` Darrick J. Wong
2018-11-15 19:21 ` Allison Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-11-15 5:58 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-xfs
On Wed, Nov 14, 2018 at 05:12:17PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
> static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 53c9ab8fb777f..e47425071e654 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -920,7 +920,7 @@ xfs_file_fallocate(
> }
>
>
> -loff_t
> +STATIC loff_t
> xfs_file_remap_range(
> struct file *file_in,
> loff_t pos_in,
> --
> 2.19.1.930.g4563a0d9d0-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: make xfs_file_remap_range() static
2018-11-15 1:12 [PATCH] xfs: make xfs_file_remap_range() static Eric Biggers
2018-11-15 5:58 ` Darrick J. Wong
@ 2018-11-15 19:21 ` Allison Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Allison Henderson @ 2018-11-15 19:21 UTC (permalink / raw)
To: Eric Biggers, linux-xfs
On 11/14/18 6:12 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
> static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 53c9ab8fb777f..e47425071e654 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -920,7 +920,7 @@ xfs_file_fallocate(
> }
>
>
> -loff_t
> +STATIC loff_t
> xfs_file_remap_range(
> struct file *file_in,
> loff_t pos_in,
>
Looks ok to me. You can add my review:
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Thanks!
Allison
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-16 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 1:12 [PATCH] xfs: make xfs_file_remap_range() static Eric Biggers
2018-11-15 5:58 ` Darrick J. Wong
2018-11-15 19:21 ` Allison Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).