linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] xfsprogs: provide a few compatibility typedefs
@ 2019-09-03 12:58 Christoph Hellwig
  2019-09-03 14:40 ` Darrick J. Wong
  2019-09-04  7:24 ` Murphy Zhou
  0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-09-03 12:58 UTC (permalink / raw)
  To: linux-xfs; +Cc: Murphy Zhou

Add back four typedefs that allow xfsdump to compile against the
headers from the latests xfsprogs.

Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/xfs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/xfs.h b/include/xfs.h
index f2f675df..9c03d6bd 100644
--- a/include/xfs.h
+++ b/include/xfs.h
@@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8];
 #include <xfs/xfs_types.h>
 #include <xfs/xfs_fs.h>
 
+/*
+ * Backards compatibility for users of this header, now that the kernel
+ * removed these typedefs from xfs_fs.h.
+ */
+typedef struct xfs_bstat xfs_bstat_t;
+typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t;
+typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t;
+typedef struct xfs_inogrp xfs_inogrp_t;
+
 #endif	/* __XFS_H__ */
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] xfsprogs: provide a few compatibility typedefs
  2019-09-03 12:58 [PATCH v3] xfsprogs: provide a few compatibility typedefs Christoph Hellwig
@ 2019-09-03 14:40 ` Darrick J. Wong
  2019-09-04  7:24 ` Murphy Zhou
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-09-03 14:40 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-xfs, Murphy Zhou

On Tue, Sep 03, 2019 at 02:58:45PM +0200, Christoph Hellwig wrote:
> Add back four typedefs that allow xfsdump to compile against the
> headers from the latests xfsprogs.
> 
> Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok (though really I looked at the previous broken version and
look how far that got us :P)

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  include/xfs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/xfs.h b/include/xfs.h
> index f2f675df..9c03d6bd 100644
> --- a/include/xfs.h
> +++ b/include/xfs.h
> @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8];
>  #include <xfs/xfs_types.h>
>  #include <xfs/xfs_fs.h>
>  
> +/*
> + * Backards compatibility for users of this header, now that the kernel
> + * removed these typedefs from xfs_fs.h.
> + */
> +typedef struct xfs_bstat xfs_bstat_t;
> +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t;
> +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t;
> +typedef struct xfs_inogrp xfs_inogrp_t;
> +
>  #endif	/* __XFS_H__ */
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] xfsprogs: provide a few compatibility typedefs
  2019-09-03 12:58 [PATCH v3] xfsprogs: provide a few compatibility typedefs Christoph Hellwig
  2019-09-03 14:40 ` Darrick J. Wong
@ 2019-09-04  7:24 ` Murphy Zhou
  1 sibling, 0 replies; 3+ messages in thread
From: Murphy Zhou @ 2019-09-04  7:24 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-xfs, Murphy Zhou

On Tue, Sep 03, 2019 at 02:58:45PM +0200, Christoph Hellwig wrote:
> Add back four typedefs that allow xfsdump to compile against the
> headers from the latests xfsprogs.
> 
> Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Works fine. Thanks~

> ---
>  include/xfs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/xfs.h b/include/xfs.h
> index f2f675df..9c03d6bd 100644
> --- a/include/xfs.h
> +++ b/include/xfs.h
> @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8];
>  #include <xfs/xfs_types.h>
>  #include <xfs/xfs_fs.h>
>  
> +/*
> + * Backards compatibility for users of this header, now that the kernel
> + * removed these typedefs from xfs_fs.h.
> + */
> +typedef struct xfs_bstat xfs_bstat_t;
> +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t;
> +typedef struct xfs_fsop_geom_v1 xfs_fsop_geom_v1_t;
> +typedef struct xfs_inogrp xfs_inogrp_t;
> +
>  #endif	/* __XFS_H__ */
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-04  7:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 12:58 [PATCH v3] xfsprogs: provide a few compatibility typedefs Christoph Hellwig
2019-09-03 14:40 ` Darrick J. Wong
2019-09-04  7:24 ` Murphy Zhou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).