From: Brian Foster <bfoster@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
David Howells <dhowells@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v5 13/17] xfs: mount api - add xfs_reconfigure()
Date: Wed, 9 Oct 2019 08:51:12 -0400 [thread overview]
Message-ID: <20191009125112.GA29646@bfoster> (raw)
In-Reply-To: <157062067944.32346.8228418435930532076.stgit@fedora-28>
On Wed, Oct 09, 2019 at 07:31:19PM +0800, Ian Kent wrote:
> Add the fs_context_operations method .reconfigure that performs
> remount validation as previously done by the super_operations
> .remount_fs method.
>
> Signed-off-by: Ian Kent <raven@themaw.net>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_super.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 7e634706626b..230b0e2a184c 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1544,6 +1544,67 @@ xfs_fs_remount(
> return 0;
> }
>
> +/*
> + * Logically we would return an error here to prevent users
> + * from believing they might have changed mount options using
> + * remount which can't be changed.
> + *
> + * But unfortunately mount(8) adds all options from mtab and
> + * fstab to the mount arguments in some cases so we can't
> + * blindly reject options, but have to check for each specified
> + * option if it actually differs from the currently set option
> + * and only reject it if that's the case.
> + *
> + * Until that is implemented we return success for every remount
> + * request, and silently ignore all options that we can't actually
> + * change.
> + */
> +STATIC int
> +xfs_reconfigure(
> + struct fs_context *fc)
> +{
> + struct xfs_fs_context *ctx = fc->fs_private;
> + struct xfs_mount *mp = XFS_M(fc->root->d_sb);
> + struct xfs_mount *new_mp = fc->s_fs_info;
> + xfs_sb_t *sbp = &mp->m_sb;
> + int flags = fc->sb_flags;
> + int error;
> +
> + error = xfs_validate_params(new_mp, ctx, false);
> + if (error)
> + return error;
> +
> + /* inode32 -> inode64 */
> + if ((mp->m_flags & XFS_MOUNT_SMALL_INUMS) &&
> + !(new_mp->m_flags & XFS_MOUNT_SMALL_INUMS)) {
> + mp->m_flags &= ~XFS_MOUNT_SMALL_INUMS;
> + mp->m_maxagi = xfs_set_inode_alloc(mp, sbp->sb_agcount);
> + }
> +
> + /* inode64 -> inode32 */
> + if (!(mp->m_flags & XFS_MOUNT_SMALL_INUMS) &&
> + (new_mp->m_flags & XFS_MOUNT_SMALL_INUMS)) {
> + mp->m_flags |= XFS_MOUNT_SMALL_INUMS;
> + mp->m_maxagi = xfs_set_inode_alloc(mp, sbp->sb_agcount);
> + }
> +
> + /* ro -> rw */
> + if ((mp->m_flags & XFS_MOUNT_RDONLY) && !(flags & SB_RDONLY)) {
> + error = xfs_remount_rw(mp);
> + if (error)
> + return error;
> + }
> +
> + /* rw -> ro */
> + if (!(mp->m_flags & XFS_MOUNT_RDONLY) && (flags & SB_RDONLY)) {
> + error = xfs_remount_ro(mp);
> + if (error)
> + return error;
> + }
> +
> + return 0;
> +}
> +
> /*
> * Second stage of a freeze. The data is already frozen so we only
> * need to take care of the metadata. Once that's done sync the superblock
> @@ -2069,6 +2130,7 @@ static const struct super_operations xfs_super_operations = {
> static const struct fs_context_operations xfs_context_ops = {
> .parse_param = xfs_parse_param,
> .get_tree = xfs_get_tree,
> + .reconfigure = xfs_reconfigure,
> };
>
> static struct file_system_type xfs_fs_type = {
>
next prev parent reply other threads:[~2019-10-09 12:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 11:30 [PATCH v5 00/17] xfs: mount API patch series Ian Kent
2019-10-09 11:30 ` [PATCH v5 01/17] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-10-09 11:30 ` [PATCH v5 02/17] vfs: add missing blkdev_put() in get_tree_bdev() Ian Kent
2019-10-09 11:30 ` [PATCH v5 03/17] xfs: remove very old mount option Ian Kent
2019-10-09 11:30 ` [PATCH v5 04/17] xfs: mount-api - add fs parameter description Ian Kent
2019-10-09 14:48 ` Christoph Hellwig
2019-10-10 0:56 ` Ian Kent
2019-10-10 6:39 ` Christoph Hellwig
2019-10-10 8:31 ` Ian Kent
2019-10-09 14:53 ` Christoph Hellwig
2019-10-09 11:30 ` [PATCH v5 05/17] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-10-09 14:48 ` Christoph Hellwig
2019-10-09 15:21 ` Al Viro
2019-10-09 15:29 ` Christoph Hellwig
2019-10-09 16:03 ` Al Viro
2019-10-09 18:01 ` Christoph Hellwig
2019-10-09 18:22 ` Al Viro
2019-12-06 8:27 ` Christoph Hellwig
2019-10-10 0:59 ` Ian Kent
2019-10-09 11:30 ` [PATCH v5 06/17] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-10-09 14:56 ` Christoph Hellwig
2019-10-10 1:08 ` Ian Kent
2019-10-09 11:30 ` [PATCH v5 07/17] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-10-09 11:30 ` [PATCH v5 08/17] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-10-09 15:02 ` Christoph Hellwig
2019-10-09 19:47 ` Darrick J. Wong
2019-10-10 6:38 ` Christoph Hellwig
2019-10-10 7:57 ` Christoph Hellwig
2019-10-09 11:30 ` [PATCH v5 09/17] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-10-09 15:03 ` Christoph Hellwig
2019-10-10 1:10 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 10/17] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-10-09 15:04 ` Christoph Hellwig
2019-10-10 1:11 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 11/17] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-10-09 11:31 ` [PATCH v5 12/17] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-10-09 11:31 ` [PATCH v5 13/17] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-10-09 12:51 ` Brian Foster [this message]
2019-10-09 15:05 ` Christoph Hellwig
2019-10-10 1:12 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 14/17] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-10-09 12:51 ` Brian Foster
2019-10-09 11:31 ` [PATCH v5 15/17] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-10-09 11:31 ` [PATCH v5 16/17] xfs: mount-api - switch to new mount-api Ian Kent
2019-10-09 15:10 ` Christoph Hellwig
2019-10-10 1:15 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 17/17] xfs: mount-api - remove remaining legacy mount code Ian Kent
2019-10-09 15:10 ` Christoph Hellwig
2019-10-10 1:17 ` Ian Kent
2019-10-09 14:52 ` [PATCH v5 00/17] xfs: mount API patch series Christoph Hellwig
2019-10-14 1:28 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009125112.GA29646@bfoster \
--to=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).