From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2/3] xfs: attach dquots and reserve quota blocks during unwritten conversion
Date: Sun, 10 Nov 2019 23:59:45 -0800 [thread overview]
Message-ID: <20191111075945.GB4548@infradead.org> (raw)
In-Reply-To: <157343510780.1948946.16275987302017348487.stgit@magnolia>
On Sun, Nov 10, 2019 at 05:18:27PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In xfs_iomap_write_unwritten, we need to ensure that dquots are attached
> to the inode and quota blocks reserved so that we capture in the quota
> counters any blocks allocated to handle a bmbt split. This can happen
> on the first unwritten extent conversion to a preallocated sparse file
> on a fresh mount.
>
> This was found by running generic/311 with quotas enabled. The bug
> seems to have been introduced in "[XFS] rework iocore infrastructure,
> remove some code and make it more" from ~2002?
Wow. The fix looks correct, but I can't see how we got away with that
for so long..
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-11-11 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:18 [PATCH 0/3] xfs: various fixes Darrick J. Wong
2019-11-11 1:18 ` [PATCH 1/3] xfs: actually check xfs_btree_check_block return in xfs_btree_islastblock Darrick J. Wong
2019-11-11 7:57 ` Christoph Hellwig
2019-11-11 1:18 ` [PATCH 2/3] xfs: attach dquots and reserve quota blocks during unwritten conversion Darrick J. Wong
2019-11-11 7:59 ` Christoph Hellwig [this message]
2019-11-11 1:18 ` [PATCH 3/3] xfs: attach dquots before performing xfs_swap_extents Darrick J. Wong
2019-11-11 8:05 ` Christoph Hellwig
2019-11-12 22:14 ` Dave Chinner
2019-11-14 14:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111075945.GB4548@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).