From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v4 2/5] xfs: remove the xfs_quotainfo_t typedef
Date: Tue, 12 Nov 2019 20:44:48 -0800 [thread overview]
Message-ID: <20191113044448.GO6219@magnolia> (raw)
In-Reply-To: <20191112213310.212925-3-preichl@redhat.com>
On Tue, Nov 12, 2019 at 10:33:07PM +0100, Pavel Reichl wrote:
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Looks fine,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_qm.c | 20 ++++++++++----------
> fs/xfs/xfs_qm.h | 6 +++---
> fs/xfs/xfs_trans_dquot.c | 2 +-
> 3 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 035930a4f0dd..64a944296fda 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -30,10 +30,10 @@
> * quota functionality, including maintaining the freelist and hash
> * tables of dquots.
> */
> -STATIC int xfs_qm_init_quotainos(xfs_mount_t *);
> -STATIC int xfs_qm_init_quotainfo(xfs_mount_t *);
> +STATIC int xfs_qm_init_quotainos(struct xfs_mount *mp);
> +STATIC int xfs_qm_init_quotainfo(struct xfs_mount *mp);
>
> -STATIC void xfs_qm_destroy_quotainos(xfs_quotainfo_t *qi);
> +STATIC void xfs_qm_destroy_quotainos(struct xfs_quotainfo *qi);
> STATIC void xfs_qm_dqfree_one(struct xfs_dquot *dqp);
> /*
> * We use the batch lookup interface to iterate over the dquots as it
> @@ -540,9 +540,9 @@ xfs_qm_shrink_count(
>
> STATIC void
> xfs_qm_set_defquota(
> - xfs_mount_t *mp,
> - uint type,
> - xfs_quotainfo_t *qinf)
> + struct xfs_mount *mp,
> + uint type,
> + struct xfs_quotainfo *qinf)
> {
> struct xfs_dquot *dqp;
> struct xfs_def_quota *defq;
> @@ -643,7 +643,7 @@ xfs_qm_init_quotainfo(
>
> ASSERT(XFS_IS_QUOTA_RUNNING(mp));
>
> - qinf = mp->m_quotainfo = kmem_zalloc(sizeof(xfs_quotainfo_t), 0);
> + qinf = mp->m_quotainfo = kmem_zalloc(sizeof(struct xfs_quotainfo), 0);
>
> error = list_lru_init(&qinf->qi_lru);
> if (error)
> @@ -710,9 +710,9 @@ xfs_qm_init_quotainfo(
> */
> void
> xfs_qm_destroy_quotainfo(
> - xfs_mount_t *mp)
> + struct xfs_mount *mp)
> {
> - xfs_quotainfo_t *qi;
> + struct xfs_quotainfo *qi;
>
> qi = mp->m_quotainfo;
> ASSERT(qi != NULL);
> @@ -1568,7 +1568,7 @@ xfs_qm_init_quotainos(
>
> STATIC void
> xfs_qm_destroy_quotainos(
> - xfs_quotainfo_t *qi)
> + struct xfs_quotainfo *qi)
> {
> if (qi->qi_uquotaip) {
> xfs_irele(qi->qi_uquotaip);
> diff --git a/fs/xfs/xfs_qm.h b/fs/xfs/xfs_qm.h
> index b41b75089548..7823af39008b 100644
> --- a/fs/xfs/xfs_qm.h
> +++ b/fs/xfs/xfs_qm.h
> @@ -54,7 +54,7 @@ struct xfs_def_quota {
> * Various quota information for individual filesystems.
> * The mount structure keeps a pointer to this.
> */
> -typedef struct xfs_quotainfo {
> +struct xfs_quotainfo {
> struct radix_tree_root qi_uquota_tree;
> struct radix_tree_root qi_gquota_tree;
> struct radix_tree_root qi_pquota_tree;
> @@ -76,8 +76,8 @@ typedef struct xfs_quotainfo {
> struct xfs_def_quota qi_usr_default;
> struct xfs_def_quota qi_grp_default;
> struct xfs_def_quota qi_prj_default;
> - struct shrinker qi_shrinker;
> -} xfs_quotainfo_t;
> + struct shrinker qi_shrinker;
> +};
>
> static inline struct radix_tree_root *
> xfs_dquot_tree(
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index 0b7f6f228662..d319347093d6 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -585,7 +585,7 @@ xfs_trans_dqresv(
> xfs_qwarncnt_t warnlimit;
> xfs_qcnt_t total_count;
> xfs_qcnt_t *resbcountp;
> - xfs_quotainfo_t *q = mp->m_quotainfo;
> + struct xfs_quotainfo *q = mp->m_quotainfo;
> struct xfs_def_quota *defq;
>
>
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-11-13 4:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 21:33 [PATCH v4 0/5] xfs: remove several typedefs in quota code Pavel Reichl
2019-11-12 21:33 ` [PATCH v4 1/5] xfs: remove the xfs_disk_dquot_t and xfs_dquot_t Pavel Reichl
2019-11-13 4:45 ` Darrick J. Wong
2019-11-14 1:29 ` Dave Chinner
2019-11-12 21:33 ` [PATCH v4 2/5] xfs: remove the xfs_quotainfo_t typedef Pavel Reichl
2019-11-13 4:44 ` Darrick J. Wong [this message]
2019-11-12 21:33 ` [PATCH v4 3/5] xfs: remove the xfs_dq_logitem_t typedef Pavel Reichl
2019-11-13 4:44 ` Darrick J. Wong
2019-11-14 1:30 ` Dave Chinner
2019-11-14 5:30 ` Pavel Reichl
2019-11-14 22:20 ` Dave Chinner
2019-11-12 21:33 ` [PATCH v4 4/5] xfs: remove the xfs_qoff_logitem_t typedef Pavel Reichl
2019-11-13 4:44 ` Darrick J. Wong
2019-11-14 1:38 ` Dave Chinner
2019-11-14 4:02 ` Darrick J. Wong
2019-11-12 21:33 ` [PATCH v4 5/5] Replace function declartion by actual definition Pavel Reichl
2019-11-13 4:43 ` Darrick J. Wong
2019-11-14 1:40 ` Dave Chinner
2019-11-14 1:28 ` [PATCH v4 0/5] xfs: remove several typedefs in quota code Dave Chinner
2019-11-14 5:25 ` Pavel Reichl
2019-11-15 0:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113044448.GO6219@magnolia \
--to=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).