Re: [PATCH v4 4/5] xfs: remove the xfs_qoff_logitem_t typedef

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Nov 14, 2019 at 12:38:43PM +1100, Dave Chinner wrote:
> On Tue, Nov 12, 2019 at 10:33:09PM +0100, Pavel Reichl wrote:
> > Signed-off-by: Pavel Reichl <preichl@redhat.com>
> > ---
> >  fs/xfs/libxfs/xfs_trans_resv.c |  5 ++---
> >  fs/xfs/xfs_dquot_item.h        | 28 +++++++++++++++-------------
> >  fs/xfs/xfs_qm_syscalls.c       | 29 ++++++++++++++++-------------
> >  fs/xfs/xfs_trans_dquot.c       | 12 ++++++------
> >  4 files changed, 39 insertions(+), 35 deletions(-)
> > 
> > diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
> > index 271cca13565b..da6642488177 100644
> > --- a/fs/xfs/libxfs/xfs_trans_resv.c
> > +++ b/fs/xfs/libxfs/xfs_trans_resv.c
> > @@ -741,8 +741,7 @@ xfs_calc_qm_dqalloc_reservation(
> >  
> >  /*
> >   * Turning off quotas.
> > - *    the xfs_qoff_logitem_t: sizeof(struct xfs_qoff_logitem) * 2
> > - *    the superblock for the quota flags: sector size
> > + * the quota off logitems: sizeof(struct xfs_qoff_logitem) * 2
> 
> Still needs the comment about the superblock. i.e. the initial
> quota-off transaction modifies the quota flags in the superblock, so
> it has to reserve space for that as well. Essentially the text of
> the comment is iterating all the items that get modified in the
> transaction and are accounted for in the function.
> 
> Everything else looks fine, though. :)

Well I /was/ about to stage the whole series for reals, so ... I'll just
fix the comments on the way in.

--D

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com