From: Dave Chinner <david@fromorbit.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mkfs: Break block discard into chunks of 2 GB
Date: Sat, 23 Nov 2019 08:00:40 +1100 [thread overview]
Message-ID: <20191122210040.GK4614@dread.disaster.area> (raw)
In-Reply-To: <CAJc7PzX0sra12ikpVAY4LE-zRxamJK+JiNxj69MS+MOTmP730g@mail.gmail.com>
On Fri, Nov 22, 2019 at 04:59:21PM +0100, Pavel Reichl wrote:
> On Fri, Nov 22, 2019 at 4:38 PM Darrick J. Wong <darrick.wong@oracle.com> wrote:
> > Also:
> > What is the end goal that you have in mind? Is the progress reporting
> > the ultimate goal? Or is it to break up the BLKDISCARD calls so that
> > someone can ^C a mkfs operation and not have it just sit there
> > continuing to run?
>
> The goal is mainly the progress reporting but the possibility to do ^C
> is also convenient. It seems that some users are not happy about the
> BLKDISCARD taking too long and at the same time not being informed
> about that - so they think that the command actually hung.
Ok, that's a good summary to put in the commit description - it
tells the reviewer exactly what you are trying to acheive, and gives
them context to evaluate it against.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-11-22 21:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 21:44 [PATCH 0/2] mkfs: inform during block discarding Pavel Reichl
2019-11-21 21:44 ` [PATCH 1/2] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
2019-11-21 21:55 ` Darrick J. Wong
2019-11-22 14:46 ` Pavel Reichl
2019-11-22 21:07 ` Eric Sandeen
2019-11-21 23:18 ` Dave Chinner
2019-11-22 15:38 ` Darrick J. Wong
2019-11-22 15:59 ` Pavel Reichl
2019-11-22 21:00 ` Dave Chinner [this message]
2019-11-22 16:09 ` Pavel Reichl
2019-11-22 21:10 ` Eric Sandeen
2019-11-22 21:30 ` Eric Sandeen
2019-11-26 19:40 ` Eric Sandeen
2019-11-26 20:53 ` Eric Sandeen
2019-11-21 21:44 ` [PATCH 2/2] mkfs: Show progress during block discard Pavel Reichl
2019-11-21 21:59 ` Darrick J. Wong
2019-11-22 16:27 ` Pavel Reichl
2019-11-22 16:31 ` Darrick J. Wong
2019-11-21 23:41 ` Dave Chinner
2019-11-22 16:43 ` Pavel Reichl
2019-11-22 21:11 ` Dave Chinner
2019-11-22 21:19 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122210040.GK4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).