* [PATCH -next] xfs: remove unused variable 'done'
@ 2020-01-17 1:50 YueHaibing
2020-01-17 6:16 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-01-17 1:50 UTC (permalink / raw)
To: darrick.wong, linux-xfs, hch; +Cc: linux-kernel, YueHaibing
fs/xfs/xfs_inode.c: In function 'xfs_itruncate_extents_flags':
fs/xfs/xfs_inode.c:1523:8: warning: unused variable 'done' [-Wunused-variable]
commit 4bbb04abb4ee ("xfs: truncate should remove
all blocks, not just to the end of the page cache")
left behind this, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/xfs/xfs_inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 1309f25..1979a00 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags(
xfs_fileoff_t first_unmap_block;
xfs_filblks_t unmap_len;
int error = 0;
- int done = 0;
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] xfs: remove unused variable 'done'
2020-01-17 1:50 [PATCH -next] xfs: remove unused variable 'done' YueHaibing
@ 2020-01-17 6:16 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-01-17 6:16 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-xfs, hch, linux-kernel
On Fri, Jan 17, 2020 at 09:50:11AM +0800, YueHaibing wrote:
> fs/xfs/xfs_inode.c: In function 'xfs_itruncate_extents_flags':
> fs/xfs/xfs_inode.c:1523:8: warning: unused variable 'done' [-Wunused-variable]
>
> commit 4bbb04abb4ee ("xfs: truncate should remove
> all blocks, not just to the end of the page cache")
> left behind this, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 1309f25..1979a00 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags(
> xfs_fileoff_t first_unmap_block;
> xfs_filblks_t unmap_len;
> int error = 0;
> - int done = 0;
>
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
> ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-17 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 1:50 [PATCH -next] xfs: remove unused variable 'done' YueHaibing
2020-01-17 6:16 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).