From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org,
Allison Collins <allison.henderson@oracle.com>
Subject: Re: [PATCH 08/29] xfs: move struct xfs_da_args to xfs_types.h
Date: Tue, 21 Jan 2020 10:48:06 -0800 [thread overview]
Message-ID: <20200121184806.GW8247@magnolia> (raw)
In-Reply-To: <20200114081051.297488-9-hch@lst.de>
On Tue, Jan 14, 2020 at 09:10:30AM +0100, Christoph Hellwig wrote:
> To allow passing a struct xfs_da_args to the high-level attr helpers
> it needs to be easily includable by files like xfs_xattr.c. Move the
> struct definition to xfs_types.h to allow for that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_da_btree.h | 64 ------------------------------------
> fs/xfs/libxfs/xfs_types.h | 60 +++++++++++++++++++++++++++++++++
> 2 files changed, 60 insertions(+), 64 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_da_btree.h b/fs/xfs/libxfs/xfs_da_btree.h
> index 0f4fbb0889ff..dd2f48b8ee07 100644
> --- a/fs/xfs/libxfs/xfs_da_btree.h
> +++ b/fs/xfs/libxfs/xfs_da_btree.h
> @@ -36,70 +36,6 @@ struct xfs_da_geometry {
> size_t data_entry_offset;
> };
>
> -/*========================================================================
> - * Btree searching and modification structure definitions.
> - *========================================================================*/
> -
> -/*
> - * Search comparison results
> - */
> -enum xfs_dacmp {
> - XFS_CMP_DIFFERENT, /* names are completely different */
> - XFS_CMP_EXACT, /* names are exactly the same */
> - XFS_CMP_CASE /* names are same but differ in case */
> -};
> -
> -/*
> - * Structure to ease passing around component names.
> - */
> -typedef struct xfs_da_args {
> - struct xfs_da_geometry *geo; /* da block geometry */
> - const uint8_t *name; /* string (maybe not NULL terminated) */
> - int namelen; /* length of string (maybe no NULL) */
> - uint8_t filetype; /* filetype of inode for directories */
> - uint8_t *value; /* set of bytes (maybe contain NULLs) */
> - int valuelen; /* length of value */
> - int flags; /* argument flags (eg: ATTR_NOCREATE) */
> - xfs_dahash_t hashval; /* hash value of name */
> - xfs_ino_t inumber; /* input/output inode number */
> - struct xfs_inode *dp; /* directory inode to manipulate */
> - struct xfs_trans *trans; /* current trans (changes over time) */
> - xfs_extlen_t total; /* total blocks needed, for 1st bmap */
> - int whichfork; /* data or attribute fork */
> - xfs_dablk_t blkno; /* blkno of attr leaf of interest */
> - int index; /* index of attr of interest in blk */
> - xfs_dablk_t rmtblkno; /* remote attr value starting blkno */
> - int rmtblkcnt; /* remote attr value block count */
> - int rmtvaluelen; /* remote attr value length in bytes */
> - xfs_dablk_t blkno2; /* blkno of 2nd attr leaf of interest */
> - int index2; /* index of 2nd attr in blk */
> - xfs_dablk_t rmtblkno2; /* remote attr value starting blkno */
> - int rmtblkcnt2; /* remote attr value block count */
> - int rmtvaluelen2; /* remote attr value length in bytes */
> - int op_flags; /* operation flags */
> - enum xfs_dacmp cmpresult; /* name compare result for lookups */
> -} xfs_da_args_t;
> -
> -/*
> - * Operation flags:
> - */
> -#define XFS_DA_OP_JUSTCHECK 0x0001 /* check for ok with no space */
> -#define XFS_DA_OP_RENAME 0x0002 /* this is an atomic rename op */
> -#define XFS_DA_OP_ADDNAME 0x0004 /* this is an add operation */
> -#define XFS_DA_OP_OKNOENT 0x0008 /* lookup/add op, ENOENT ok, else die */
> -#define XFS_DA_OP_CILOOKUP 0x0010 /* lookup to return CI name if found */
> -#define XFS_DA_OP_ALLOCVAL 0x0020 /* lookup to alloc buffer if found */
> -#define XFS_DA_OP_INCOMPLETE 0x0040 /* lookup INCOMPLETE attr keys */
> -
> -#define XFS_DA_OP_FLAGS \
> - { XFS_DA_OP_JUSTCHECK, "JUSTCHECK" }, \
> - { XFS_DA_OP_RENAME, "RENAME" }, \
> - { XFS_DA_OP_ADDNAME, "ADDNAME" }, \
> - { XFS_DA_OP_OKNOENT, "OKNOENT" }, \
> - { XFS_DA_OP_CILOOKUP, "CILOOKUP" }, \
> - { XFS_DA_OP_ALLOCVAL, "ALLOCVAL" }, \
> - { XFS_DA_OP_INCOMPLETE, "INCOMPLETE" }
> -
> /*
> * Storage for holding state during Btree searches and split/join ops.
> *
> diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
> index 397d94775440..e2711d119665 100644
> --- a/fs/xfs/libxfs/xfs_types.h
> +++ b/fs/xfs/libxfs/xfs_types.h
> @@ -175,6 +175,66 @@ enum xfs_ag_resv_type {
> XFS_AG_RESV_RMAPBT,
> };
>
> +/*
> + * Dir/attr btree search comparison results.
> + */
> +enum xfs_dacmp {
> + XFS_CMP_DIFFERENT, /* names are completely different */
> + XFS_CMP_EXACT, /* names are exactly the same */
> + XFS_CMP_CASE /* names are same but differ in case */
> +};
> +
> +/*
> + * Structure to ease passing around dir/attr component names.
> + */
> +typedef struct xfs_da_args {
> + struct xfs_da_geometry *geo; /* da block geometry */
> + const uint8_t *name; /* string (maybe not NULL terminated) */
> + int namelen; /* length of string (maybe no NULL) */
> + uint8_t filetype; /* filetype of inode for directories */
> + uint8_t *value; /* set of bytes (maybe contain NULLs) */
> + int valuelen; /* length of value */
> + int flags; /* argument flags (eg: ATTR_NOCREATE) */
> + xfs_dahash_t hashval; /* hash value of name */
> + xfs_ino_t inumber; /* input/output inode number */
> + struct xfs_inode *dp; /* directory inode to manipulate */
> + struct xfs_trans *trans; /* current trans (changes over time) */
> + xfs_extlen_t total; /* total blocks needed, for 1st bmap */
> + int whichfork; /* data or attribute fork */
> + xfs_dablk_t blkno; /* blkno of attr leaf of interest */
> + int index; /* index of attr of interest in blk */
> + xfs_dablk_t rmtblkno; /* remote attr value starting blkno */
> + int rmtblkcnt; /* remote attr value block count */
> + int rmtvaluelen; /* remote attr value length in bytes */
> + xfs_dablk_t blkno2; /* blkno of 2nd attr leaf of interest */
> + int index2; /* index of 2nd attr in blk */
> + xfs_dablk_t rmtblkno2; /* remote attr value starting blkno */
> + int rmtblkcnt2; /* remote attr value block count */
> + int rmtvaluelen2; /* remote attr value length in bytes */
> + int op_flags; /* operation flags */
> + enum xfs_dacmp cmpresult; /* name compare result for lookups */
> +} xfs_da_args_t;
> +
> +/*
> + * Operation flags:
> + */
> +#define XFS_DA_OP_JUSTCHECK 0x0001 /* check for ok with no space */
> +#define XFS_DA_OP_RENAME 0x0002 /* this is an atomic rename op */
> +#define XFS_DA_OP_ADDNAME 0x0004 /* this is an add operation */
> +#define XFS_DA_OP_OKNOENT 0x0008 /* lookup/add op, ENOENT ok, else die */
> +#define XFS_DA_OP_CILOOKUP 0x0010 /* lookup to return CI name if found */
> +#define XFS_DA_OP_ALLOCVAL 0x0020 /* lookup to alloc buffer if found */
> +#define XFS_DA_OP_INCOMPLETE 0x0040 /* lookup INCOMPLETE attr keys */
> +
> +#define XFS_DA_OP_FLAGS \
> + { XFS_DA_OP_JUSTCHECK, "JUSTCHECK" }, \
> + { XFS_DA_OP_RENAME, "RENAME" }, \
> + { XFS_DA_OP_ADDNAME, "ADDNAME" }, \
> + { XFS_DA_OP_OKNOENT, "OKNOENT" }, \
> + { XFS_DA_OP_CILOOKUP, "CILOOKUP" }, \
> + { XFS_DA_OP_ALLOCVAL, "ALLOCVAL" }, \
> + { XFS_DA_OP_INCOMPLETE, "INCOMPLETE" }
> +
> /*
> * Type verifier functions
> */
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-01-21 18:48 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 8:10 clean up the attr interface v2 Christoph Hellwig
2020-01-14 8:10 ` [PATCH 01/29] xfs: remove the ATTR_INCOMPLETE flag Christoph Hellwig
2020-01-17 0:59 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 02/29] xfs: merge xfs_attr_remove into xfs_attr_set Christoph Hellwig
2020-01-21 17:28 ` Darrick J. Wong
2020-01-25 4:17 ` Allison Collins
2020-01-25 23:22 ` Christoph Hellwig
2020-01-26 22:23 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 03/29] xfs: merge xfs_attrmulti_attr_remove into xfs_attrmulti_attr_set Christoph Hellwig
2020-01-21 17:41 ` Darrick J. Wong
2020-01-23 22:33 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 04/29] xfs: use strndup_user in XFS_IOC_ATTRMULTI_BY_HANDLE Christoph Hellwig
2020-01-21 17:45 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 05/29] xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op Christoph Hellwig
2020-01-21 17:54 ` Darrick J. Wong
2020-01-23 22:34 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 06/29] xfs: remove the name == NULL check from xfs_attr_args_init Christoph Hellwig
2020-01-21 17:57 ` Darrick J. Wong
2020-01-23 22:35 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 07/29] xfs: remove the MAXNAMELEN " Christoph Hellwig
2020-01-21 18:03 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 08/29] xfs: move struct xfs_da_args to xfs_types.h Christoph Hellwig
2020-01-21 18:48 ` Darrick J. Wong [this message]
2020-01-14 8:10 ` [PATCH 09/29] xfs: turn xfs_da_args.value into a void pointer Christoph Hellwig
2020-01-21 18:07 ` Darrick J. Wong
2020-01-23 22:36 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 10/29] xfs: pass an initialized xfs_da_args structure to xfs_attr_set Christoph Hellwig
2020-01-21 18:10 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 11/29] xfs: pass an initialized xfs_da_args to xfs_attr_get Christoph Hellwig
2020-01-21 18:12 ` Darrick J. Wong
2020-01-23 22:39 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 12/29] xfs: remove the xfs_inode argument to xfs_attr_get_ilocked Christoph Hellwig
2020-01-21 18:13 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 13/29] xfs: remove ATTR_KERNOVAL Christoph Hellwig
2020-01-21 18:15 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 14/29] xfs: remove ATTR_ALLOC and XFS_DA_OP_ALLOCVAL Christoph Hellwig
2020-01-21 18:17 ` Darrick J. Wong
2020-01-23 22:40 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 15/29] xfs: replace ATTR_KERNOTIME with XFS_DA_OP_NOTIME Christoph Hellwig
2020-01-21 18:20 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 16/29] xfs: factor out a xfs_attr_match helper Christoph Hellwig
2020-01-21 18:27 ` Darrick J. Wong
2020-01-23 22:41 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 17/29] xfs: cleanup xfs_attr_list_context Christoph Hellwig
2020-01-21 18:30 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 18/29] xfs: remove the unused ATTR_ENTRY macro Christoph Hellwig
2020-01-21 18:33 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 19/29] xfs: replace ATTR_ENTBASESIZE with offsetoff Christoph Hellwig
2020-01-21 18:36 ` Darrick J. Wong
2020-01-23 22:43 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 20/29] xfs: move the legacy xfs_attr_list to xfs_ioctl.c Christoph Hellwig
2020-01-21 18:41 ` Darrick J. Wong
2020-01-24 23:13 ` Christoph Hellwig
2020-01-14 8:10 ` [PATCH 21/29] xfs: rename xfs_attr_list_int to xfs_attr_list Christoph Hellwig
2020-01-21 18:42 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 22/29] xfs: lift common checks into xfs_ioc_attr_list Christoph Hellwig
2020-01-21 18:43 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 23/29] xfs: lift buffer allocation " Christoph Hellwig
2020-01-21 18:49 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 24/29] xfs: lift cursor copy in/out " Christoph Hellwig
2020-01-21 18:52 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 25/29] xfs: improve xfs_forget_acl Christoph Hellwig
2020-01-21 18:56 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 26/29] xfs: clean up the ATTR_REPLACE checks Christoph Hellwig
2020-01-21 18:57 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 27/29] xfs: clean up the attr flag confusion Christoph Hellwig
2020-01-21 19:44 ` Darrick J. Wong
2020-01-24 23:24 ` Christoph Hellwig
2020-01-25 23:10 ` Christoph Hellwig
2020-01-26 22:24 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 28/29] xfs: remove XFS_DA_OP_INCOMPLETE Christoph Hellwig
2020-01-21 19:45 ` Darrick J. Wong
2020-01-14 8:10 ` [PATCH 29/29] xfs: embedded the attrlist cursor into struct xfs_attr_list_context Christoph Hellwig
2020-01-21 19:04 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121184806.GW8247@magnolia \
--to=darrick.wong@oracle.com \
--cc=allison.henderson@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).