* [PATCH] xfs: remove unnecessary variable
@ 2020-01-24 5:22 Darrick J. Wong
2020-01-24 5:24 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-01-24 5:22 UTC (permalink / raw)
To: xfs; +Cc: Stephen Rothwell
From: Darrick J. Wong <darrick.wong@oracle.com>
Stephen Rothwell reported an unused variable. Remove it.
Fixes: 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 1309f25c0d2b..1979a0055763 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags(
xfs_fileoff_t first_unmap_block;
xfs_filblks_t unmap_len;
int error = 0;
- int done = 0;
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: remove unnecessary variable
2020-01-24 5:22 [PATCH] xfs: remove unnecessary variable Darrick J. Wong
@ 2020-01-24 5:24 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-01-24 5:24 UTC (permalink / raw)
To: xfs; +Cc: Stephen Rothwell
On Thu, Jan 23, 2020 at 09:22:10PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Stephen Rothwell reported an unused variable. Remove it.
>
> Fixes: 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
self NAK, YueHaibing already sent this, which going through bash history
I evidently misapplied and ... yeah. I've lost my marbles. :(
--D
> ---
> fs/xfs/xfs_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 1309f25c0d2b..1979a0055763 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -1520,7 +1520,6 @@ xfs_itruncate_extents_flags(
> xfs_fileoff_t first_unmap_block;
> xfs_filblks_t unmap_len;
> int error = 0;
> - int done = 0;
>
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
> ASSERT(!atomic_read(&VFS_I(ip)->i_count) ||
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-24 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-24 5:22 [PATCH] xfs: remove unnecessary variable Darrick J. Wong
2020-01-24 5:24 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).