From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Brian Foster <bfoster@redhat.com>,
Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: force writes to delalloc regions to unwritten
Date: Mon, 18 May 2020 17:40:51 -0700 [thread overview]
Message-ID: <20200519004051.GF17627@magnolia> (raw)
In-Reply-To: <20200517074843.GC32627@infradead.org>
On Sun, May 17, 2020 at 12:48:43AM -0700, Christoph Hellwig wrote:
> On Thu, May 14, 2020 at 01:44:48PM -0400, Brian Foster wrote:
> > It looks like Christoph already reviewed the patch. I'm not sure if his
> > opinion changed it all after the subsequent discussion, but otherwise
> > that just leaves Dave's objection. Dave, any thoughts on this given the
> > test results and broader context? What do you think about getting this
> > patch merged and revisiting the whole unwritten extent thing
> > independently?
>
> Absolutely no change of mind. I think we need to fix the issue ASAP
> and then look into performance improvements as soon as we get to it.
Hm, well, I do have a couple more patches to fix a couple of minor
regressions that fstests found...
--D
next prev parent reply other threads:[~2020-05-19 0:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 6:15 [PATCH 0/2] xfs: fix stale disk exposure after crash Darrick J. Wong
2020-01-16 6:15 ` [PATCH 1/2] xfs: force writes to delalloc regions to unwritten Darrick J. Wong
2020-01-16 16:47 ` Christoph Hellwig
2020-01-16 23:16 ` Darrick J. Wong
2020-01-19 20:49 ` Dave Chinner
2020-02-03 20:14 ` Darrick J. Wong
2020-05-07 10:32 ` Brian Foster
2020-05-14 16:33 ` Darrick J. Wong
2020-05-14 17:44 ` Brian Foster
2020-05-17 7:48 ` Christoph Hellwig
2020-05-19 0:40 ` Darrick J. Wong [this message]
2020-05-20 1:03 ` Dave Chinner
2020-01-16 6:15 ` [PATCH 2/2] xfs: relax unwritten writeback overhead under some circumstances Darrick J. Wong
2020-01-16 16:49 ` Christoph Hellwig
2020-01-16 23:15 ` Darrick J. Wong
2020-01-16 16:49 ` [PATCH 0/2] xfs: fix stale disk exposure after crash Christoph Hellwig
2020-01-16 23:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519004051.GF17627@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).