* [PATCH] xfs: remove useless definitions in xfs_linux.h
@ 2020-06-24 15:08 Yafang Shao
2020-06-26 9:00 ` Christoph Hellwig
2020-07-02 15:38 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Yafang Shao @ 2020-06-24 15:08 UTC (permalink / raw)
To: david, darrick.wong, hch; +Cc: linux-xfs, Yafang Shao
Remove current_pid(), current_test_flags() and
current_clear_flags_nested(), because they are useless.
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
fs/xfs/xfs_linux.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index 9f70d2f..ab737fe 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -102,12 +102,8 @@
#define xfs_cowb_secs xfs_params.cowb_timer.val
#define current_cpu() (raw_smp_processor_id())
-#define current_pid() (current->pid)
-#define current_test_flags(f) (current->flags & (f))
#define current_set_flags_nested(sp, f) \
(*(sp) = current->flags, current->flags |= (f))
-#define current_clear_flags_nested(sp, f) \
- (*(sp) = current->flags, current->flags &= ~(f))
#define current_restore_flags_nested(sp, f) \
(current->flags = ((current->flags & ~(f)) | (*(sp) & (f))))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove useless definitions in xfs_linux.h
2020-06-24 15:08 [PATCH] xfs: remove useless definitions in xfs_linux.h Yafang Shao
@ 2020-06-26 9:00 ` Christoph Hellwig
2020-07-02 15:38 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-06-26 9:00 UTC (permalink / raw)
To: Yafang Shao; +Cc: david, darrick.wong, hch, linux-xfs
On Wed, Jun 24, 2020 at 11:08:48AM -0400, Yafang Shao wrote:
> Remove current_pid(), current_test_flags() and
> current_clear_flags_nested(), because they are useless.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove useless definitions in xfs_linux.h
2020-06-24 15:08 [PATCH] xfs: remove useless definitions in xfs_linux.h Yafang Shao
2020-06-26 9:00 ` Christoph Hellwig
@ 2020-07-02 15:38 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-02 15:38 UTC (permalink / raw)
To: Yafang Shao; +Cc: david, hch, linux-xfs
On Wed, Jun 24, 2020 at 11:08:48AM -0400, Yafang Shao wrote:
> Remove current_pid(), current_test_flags() and
> current_clear_flags_nested(), because they are useless.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Looks ok, will put in tree...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_linux.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index 9f70d2f..ab737fe 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -102,12 +102,8 @@
> #define xfs_cowb_secs xfs_params.cowb_timer.val
>
> #define current_cpu() (raw_smp_processor_id())
> -#define current_pid() (current->pid)
> -#define current_test_flags(f) (current->flags & (f))
> #define current_set_flags_nested(sp, f) \
> (*(sp) = current->flags, current->flags |= (f))
> -#define current_clear_flags_nested(sp, f) \
> - (*(sp) = current->flags, current->flags &= ~(f))
> #define current_restore_flags_nested(sp, f) \
> (current->flags = ((current->flags & ~(f)) | (*(sp) & (f))))
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-02 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 15:08 [PATCH] xfs: remove useless definitions in xfs_linux.h Yafang Shao
2020-06-26 9:00 ` Christoph Hellwig
2020-07-02 15:38 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).