From: Bill O'Donnell <billodo@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, sandeen@sandeen.net, darrick.wong@oracle.com
Subject: Re: [PATCH 1/3] xfsprogs: xfs_quota command error message improvement
Date: Tue, 21 Jul 2020 10:55:52 -0500 [thread overview]
Message-ID: <20200721155552.GA96787@redhat.com> (raw)
In-Reply-To: <20200721150404.GA8201@infradead.org>
On Tue, Jul 21, 2020 at 04:04:04PM +0100, Christoph Hellwig wrote:
> On Wed, Jul 15, 2020 at 03:12:51PM -0500, Bill O'Donnell wrote:
> > Make the error messages for rudimentary xfs_quota commands
> > (off, enable, disable) more user friendly, instead of the
> > terse sys error outputs.
> >
> > Signed-off-by: Bill O'Donnell <billodo@redhat.com>
>
> I think we should have one helper with the error message
> instead of duplicating them three times.
>
Except that the error messages are different depending on the context,
so crafting a helper function that recognizes the context seems to
offer diminishing return AFAICT.
Thanks-
Bill
next prev parent reply other threads:[~2020-07-21 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 20:12 [PATCH 0/3] xfsprogs: xfs_quota error message and state reporting improvement Bill O'Donnell
2020-07-15 20:12 ` [PATCH 1/3] xfsprogs: xfs_quota command error message improvement Bill O'Donnell
2020-07-17 21:10 ` Darrick J. Wong
2020-07-21 15:04 ` Christoph Hellwig
2020-07-21 15:55 ` Bill O'Donnell [this message]
2020-07-15 20:12 ` [PATCH 2/3] xfs_quota: display warning limits when printing quota type information Bill O'Donnell
2020-07-15 20:12 ` [PATCH 3/3] xfsprogs: xfs_quota state command should report ugp grace times Bill O'Donnell
2020-07-15 20:33 ` Eric Sandeen
2020-07-15 20:44 ` Bill O'Donnell
2020-07-17 20:43 ` [PATCH v2 " Bill O'Donnell
2020-07-17 21:13 ` Darrick J. Wong
2020-07-21 15:05 ` Christoph Hellwig
2020-07-30 17:46 ` [PATCH 0/3] xfsprogs: xfs_quota error message and state reporting improvement Eric Sandeen
2020-07-30 17:52 ` Bill O'Donnell
2020-07-30 18:30 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721155552.GA96787@redhat.com \
--to=billodo@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).