From: Eric Sandeen <sandeen@sandeen.net>
To: Bill O'Donnell <billodo@redhat.com>, linux-xfs@vger.kernel.org
Cc: darrick.wong@oracle.com
Subject: Re: [PATCH 0/3] xfsprogs: xfs_quota error message and state reporting improvement
Date: Thu, 30 Jul 2020 10:46:18 -0700 [thread overview]
Message-ID: <910cf53e-62fe-c4b4-2892-5b5cd0821ac3@sandeen.net> (raw)
In-Reply-To: <20200715201253.171356-1-billodo@redhat.com>
On 7/15/20 1:12 PM, Bill O'Donnell wrote:
>
> This patchset improves xfs_quota command error message output as well as
> adding reporting for grace times and warning limits for state (u,g,p).
>
> Note that patches to xfstests to handle these changes will be forthcoming.
> Also, patch 1 was originally submitted separately:
> (xfsprogs: xfs_quota command error message improvement)
>
> patch 1 contains the command error message improvements.
> patch 2 contains the warning limit reporting (originally SoB Darrick Wong).
> patch 3 contains the additional state reporting of grace times for u,g,p.
>
> Comments appreciated. Thanks-
> Bill
Hi Bill -
These look good and have reviews, but we need xfstests fixed up with filters
now, multiple tests now have output that doesn't match expected, causing
failures:
xfs/106 - output mismatch (see /root/xfstests-dev/results//xfs/106.out.bad)
--- tests/xfs/106.out 2017-08-28 12:17:34.950134054 -0400
+++ /root/xfstests-dev/results//xfs/106.out.bad 2020-07-30 13:34:26.889836623 -0400
@@ -102,7 +102,9 @@
Enforcement: OFF
Inode: #[INO] (X blocks, Y extents)
Blocks grace time: [3 days]
+Blocks max warnings: 5
Inodes grace time: [3 days]
+Inodes max warnings: 5
Realtime Blocks grace time: [7 days]
Thanks,
-Eric
next prev parent reply other threads:[~2020-07-30 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 20:12 [PATCH 0/3] xfsprogs: xfs_quota error message and state reporting improvement Bill O'Donnell
2020-07-15 20:12 ` [PATCH 1/3] xfsprogs: xfs_quota command error message improvement Bill O'Donnell
2020-07-17 21:10 ` Darrick J. Wong
2020-07-21 15:04 ` Christoph Hellwig
2020-07-21 15:55 ` Bill O'Donnell
2020-07-15 20:12 ` [PATCH 2/3] xfs_quota: display warning limits when printing quota type information Bill O'Donnell
2020-07-15 20:12 ` [PATCH 3/3] xfsprogs: xfs_quota state command should report ugp grace times Bill O'Donnell
2020-07-15 20:33 ` Eric Sandeen
2020-07-15 20:44 ` Bill O'Donnell
2020-07-17 20:43 ` [PATCH v2 " Bill O'Donnell
2020-07-17 21:13 ` Darrick J. Wong
2020-07-21 15:05 ` Christoph Hellwig
2020-07-30 17:46 ` Eric Sandeen [this message]
2020-07-30 17:52 ` [PATCH 0/3] xfsprogs: xfs_quota error message and state reporting improvement Bill O'Donnell
2020-07-30 18:30 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910cf53e-62fe-c4b4-2892-5b5cd0821ac3@sandeen.net \
--to=sandeen@sandeen.net \
--cc=billodo@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).