From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <david@fromorbit.com>,
Eric Sandeen <sandeen@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix boundary test in xfs_attr_shortform_verify
Date: Thu, 27 Aug 2020 09:11:59 +0100 [thread overview]
Message-ID: <20200827081159.GB7605@infradead.org> (raw)
In-Reply-To: <20200826151300.GM6096@magnolia>
On Wed, Aug 26, 2020 at 08:13:00AM -0700, Darrick J. Wong wrote:
> > ditto for degree of commenting on magical -1's; on the one hand it's a
> > common usage. On the other hand, we often get it wrong so a comment
> > probably would help.
> >
> > > Did you audit the code for other occurrences of this same problem?
>
> TBH I think this ought to be fixed by changing the declaration of
> xfs_attr_sf_entry.nameval to "uint8_t nameval[]" and using more modern
> fugly macros like struct_sizeof() to calculate the entry sizes without
> us all having to remember to subtract one from the struct size.
Agreed that we absoutely need to do that. It might be worth to
have the "simple" fix as a backportable small patch first, though.
next prev parent reply other threads:[~2020-08-27 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:25 [PATCH] xfs: fix boundary test in xfs_attr_shortform_verify Eric Sandeen
2020-08-25 20:26 ` Darrick J. Wong
2020-08-25 22:41 ` Dave Chinner
2020-08-26 14:32 ` Eric Sandeen
2020-08-26 15:13 ` Darrick J. Wong
2020-08-26 15:39 ` Eric Sandeen
2020-08-26 15:43 ` Darrick J. Wong
2020-08-27 8:11 ` Christoph Hellwig [this message]
2020-08-26 16:19 ` [PATCH V2] " Eric Sandeen
2020-08-26 16:44 ` Darrick J. Wong
2020-08-26 17:07 ` Eric Sandeen
2020-09-01 12:59 ` Pavel Reichl
2020-08-27 8:12 ` Christoph Hellwig
2020-08-27 13:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827081159.GB7605@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).