From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2] xfs: fix boundary test in xfs_attr_shortform_verify
Date: Wed, 26 Aug 2020 12:07:23 -0500 [thread overview]
Message-ID: <aae7d7e5-956b-a5ba-a085-93da412895c4@sandeen.net> (raw)
In-Reply-To: <20200826164420.GP6096@magnolia>
On 8/26/20 11:44 AM, Darrick J. Wong wrote:
> On Wed, Aug 26, 2020 at 11:19:54AM -0500, Eric Sandeen wrote:
>> The boundary test for the fixed-offset parts of xfs_attr_sf_entry in
>> xfs_attr_shortform_verify is off by one, because the variable array
>> at the end is defined as nameval[1] not nameval[].
>> Hence we need to subtract 1 from the calculation.
>>
>> This can be shown by:
>>
>> # touch file
>> # setfattr -n root.a file
>>
>> and verifications will fail when it's written to disk.
>>
>> This only matters for a last attribute which has a single-byte name
>> and no value, otherwise the combination of namelen & valuelen will
>> push endp further out and this test won't fail.
>>
>> Fixes: 1e1bbd8e7ee06 ("xfs: create structure verifier function for shortform xattrs")
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks ok.
thanks
> From whom should I be expecting a test case?
from me or a TBD delegate. Will follow up soon.
-Eric
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
next prev parent reply other threads:[~2020-08-26 17:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 20:25 [PATCH] xfs: fix boundary test in xfs_attr_shortform_verify Eric Sandeen
2020-08-25 20:26 ` Darrick J. Wong
2020-08-25 22:41 ` Dave Chinner
2020-08-26 14:32 ` Eric Sandeen
2020-08-26 15:13 ` Darrick J. Wong
2020-08-26 15:39 ` Eric Sandeen
2020-08-26 15:43 ` Darrick J. Wong
2020-08-27 8:11 ` Christoph Hellwig
2020-08-26 16:19 ` [PATCH V2] " Eric Sandeen
2020-08-26 16:44 ` Darrick J. Wong
2020-08-26 17:07 ` Eric Sandeen [this message]
2020-09-01 12:59 ` Pavel Reichl
2020-08-27 8:12 ` Christoph Hellwig
2020-08-27 13:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aae7d7e5-956b-a5ba-a085-93da412895c4@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).