* [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users
@ 2020-08-30 1:30 Qian Cai
2020-08-31 0:30 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2020-08-30 1:30 UTC (permalink / raw)
To: darrick.wong; +Cc: hch, linux-xfs, linux-fsdevel, linux-kernel, Qian Cai
It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
unprivileged users which would taint the kernel, or worse - panic if
panic_on_warn or panic_on_taint is set. Hence, just convert it to
pr_warn_ratelimited() to let users know their workloads are racing.
Thanks Dave Chinner for the initial analysis of the racing reproducers.
Signed-off-by: Qian Cai <cai@lca.pw>
---
fs/iomap/direct-io.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index c1aafb2ab990..6a6b4bc13269 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -389,7 +389,14 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,
case IOMAP_INLINE:
return iomap_dio_inline_actor(inode, pos, length, dio, iomap);
default:
- WARN_ON_ONCE(1);
+ /*
+ * DIO is not serialised against mmap() access at all, and so
+ * if the page_mkwrite occurs between the writeback and the
+ * iomap_apply() call in the DIO path, then it will see the
+ * DELALLOC block that the page-mkwrite allocated.
+ */
+ pr_warn_ratelimited("page_mkwrite() is racing with DIO read (iomap->type = %u).\n",
+ iomap->type);
return -EIO;
}
}
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users
2020-08-30 1:30 [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users Qian Cai
@ 2020-08-31 0:30 ` Darrick J. Wong
2020-08-31 0:46 ` Qian Cai
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2020-08-31 0:30 UTC (permalink / raw)
To: Qian Cai; +Cc: hch, linux-xfs, linux-fsdevel, linux-kernel
On Sat, Aug 29, 2020 at 09:30:57PM -0400, Qian Cai wrote:
> It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
> unprivileged users which would taint the kernel, or worse - panic if
> panic_on_warn or panic_on_taint is set. Hence, just convert it to
> pr_warn_ratelimited() to let users know their workloads are racing.
> Thanks Dave Chinner for the initial analysis of the racing reproducers.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> fs/iomap/direct-io.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index c1aafb2ab990..6a6b4bc13269 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -389,7 +389,14 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,
> case IOMAP_INLINE:
> return iomap_dio_inline_actor(inode, pos, length, dio, iomap);
> default:
> - WARN_ON_ONCE(1);
> + /*
> + * DIO is not serialised against mmap() access at all, and so
> + * if the page_mkwrite occurs between the writeback and the
> + * iomap_apply() call in the DIO path, then it will see the
> + * DELALLOC block that the page-mkwrite allocated.
> + */
> + pr_warn_ratelimited("page_mkwrite() is racing with DIO read (iomap->type = %u).\n",
> + iomap->type);
Shouldn't we log the name of triggering process and the file path? Sort
of like what dio_warn_stale_pagecache does?
--D
> return -EIO;
> }
> }
> --
> 2.18.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users
2020-08-31 0:30 ` Darrick J. Wong
@ 2020-08-31 0:46 ` Qian Cai
0 siblings, 0 replies; 3+ messages in thread
From: Qian Cai @ 2020-08-31 0:46 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: hch, linux-xfs, linux-fsdevel, linux-kernel
On Sun, Aug 30, 2020 at 05:30:33PM -0700, Darrick J. Wong wrote:
> On Sat, Aug 29, 2020 at 09:30:57PM -0400, Qian Cai wrote:
> > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
> > unprivileged users which would taint the kernel, or worse - panic if
> > panic_on_warn or panic_on_taint is set. Hence, just convert it to
> > pr_warn_ratelimited() to let users know their workloads are racing.
> > Thanks Dave Chinner for the initial analysis of the racing reproducers.
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
> > fs/iomap/direct-io.c | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> > index c1aafb2ab990..6a6b4bc13269 100644
> > --- a/fs/iomap/direct-io.c
> > +++ b/fs/iomap/direct-io.c
> > @@ -389,7 +389,14 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,
> > case IOMAP_INLINE:
> > return iomap_dio_inline_actor(inode, pos, length, dio, iomap);
> > default:
> > - WARN_ON_ONCE(1);
> > + /*
> > + * DIO is not serialised against mmap() access at all, and so
> > + * if the page_mkwrite occurs between the writeback and the
> > + * iomap_apply() call in the DIO path, then it will see the
> > + * DELALLOC block that the page-mkwrite allocated.
> > + */
> > + pr_warn_ratelimited("page_mkwrite() is racing with DIO read (iomap->type = %u).\n",
> > + iomap->type);
>
> Shouldn't we log the name of triggering process and the file path? Sort
> of like what dio_warn_stale_pagecache does?
Good idea. I'll add them.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-31 0:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-30 1:30 [PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users Qian Cai
2020-08-31 0:30 ` Darrick J. Wong
2020-08-31 0:46 ` Qian Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).