From: Dave Chinner <david@fromorbit.com>
To: Hao Li <lihao2018.fnst@cn.fujitsu.com>
Cc: viro@zeniv.linux.org.uk, ira.weiny@intel.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, y-goto@fujitsu.com
Subject: Re: [PATCH] fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()
Date: Fri, 4 Sep 2020 07:58:32 +1000 [thread overview]
Message-ID: <20200903215832.GF12131@dread.disaster.area> (raw)
In-Reply-To: <20200831101313.168889-1-lihao2018.fnst@cn.fujitsu.com>
On Mon, Aug 31, 2020 at 06:13:13PM +0800, Hao Li wrote:
> If generic_drop_inode() returns true, it means iput_final() can evict
> this inode regardless of whether it is dirty or not. If we check
> I_DONTCACHE in generic_drop_inode(), any inode with this bit set will be
> evicted unconditionally. This is not the desired behavior because
> I_DONTCACHE only means the inode shouldn't be cached on the LRU list.
> As for whether we need to evict this inode, this is what
> generic_drop_inode() should do. This patch corrects the usage of
> I_DONTCACHE.
>
> This patch was proposed in [1].
>
> [1]: https://lore.kernel.org/linux-fsdevel/20200831003407.GE12096@dread.disaster.area/
>
> Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com>
> ---
> fs/inode.c | 3 ++-
> include/linux/fs.h | 3 +--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 72c4c347afb7..4e45d5ea3d0f 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1625,7 +1625,8 @@ static void iput_final(struct inode *inode)
> else
> drop = generic_drop_inode(inode);
>
> - if (!drop && (sb->s_flags & SB_ACTIVE)) {
> + if (!drop && !(inode->i_state & I_DONTCACHE) &&
> + (sb->s_flags & SB_ACTIVE)) {
FWIW, the format used in fs/inode.c is to align the logic
statements, not tab indent the additional lines in the statement.
i.e.
if (!drop &&
!(inode->i_state & I_DONTCACHE) &&
(sb->s_flags & SB_ACTIVE)) {
Which gives a clear indication that there are all at the same
precedence and separate logic statements...
Otherwise the change looks good.
Probably best to resend with the fixes tag :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-09-03 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:13 [PATCH] fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode() Hao Li
2020-08-31 17:12 ` Ira Weiny
2020-09-01 3:48 ` Li, Hao
2020-09-03 21:58 ` Dave Chinner [this message]
2020-09-04 7:07 ` Li, Hao
2020-11-10 2:56 Hao Li
2020-12-08 2:08 Hao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903215832.GF12131@dread.disaster.area \
--to=david@fromorbit.com \
--cc=ira.weiny@intel.com \
--cc=lihao2018.fnst@cn.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=y-goto@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).