* [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce
@ 2020-12-07 11:41 xiakaixu1987
2020-12-07 17:01 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-12-07 11:41 UTC (permalink / raw)
To: fstests; +Cc: guaneryu, linux-xfs, darrick.wong, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The mount options uqnoenforce and qnoenforce no longer cause 'usrquota'
to be emitted in /proc/mounts, so there is a regression in xfs/513. Fix
it by using proper output option uqnoenforce.
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
tests/xfs/513 | 4 ++--
tests/xfs/513.out | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/xfs/513 b/tests/xfs/513
index dfb25a8b..9045dbb5 100755
--- a/tests/xfs/513
+++ b/tests/xfs/513
@@ -302,8 +302,8 @@ do_test "" pass "usrquota" "false"
do_test "-o uquota" pass "usrquota" "true"
do_test "-o usrquota" pass "usrquota" "true"
do_test "-o quota" pass "usrquota" "true"
-do_test "-o uqnoenforce" pass "usrquota" "true"
-do_test "-o qnoenforce" pass "usrquota" "true"
+do_test "-o uqnoenforce" pass "uqnoenforce" "true"
+do_test "-o qnoenforce" pass "uqnoenforce" "true"
# Test gquota/grpquota/gqnoenforce
do_test "" pass "grpquota" "false"
diff --git a/tests/xfs/513.out b/tests/xfs/513.out
index 6681a7e8..eec8155d 100644
--- a/tests/xfs/513.out
+++ b/tests/xfs/513.out
@@ -76,8 +76,8 @@ TEST: "" "pass" "usrquota" "false"
TEST: "-o uquota" "pass" "usrquota" "true"
TEST: "-o usrquota" "pass" "usrquota" "true"
TEST: "-o quota" "pass" "usrquota" "true"
-TEST: "-o uqnoenforce" "pass" "usrquota" "true"
-TEST: "-o qnoenforce" "pass" "usrquota" "true"
+TEST: "-o uqnoenforce" "pass" "uqnoenforce" "true"
+TEST: "-o qnoenforce" "pass" "uqnoenforce" "true"
TEST: "" "pass" "grpquota" "false"
TEST: "-o gquota" "pass" "grpquota" "true"
TEST: "-o grpquota" "pass" "grpquota" "true"
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce
2020-12-07 11:41 [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce xiakaixu1987
@ 2020-12-07 17:01 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-12-07 17:01 UTC (permalink / raw)
To: xiakaixu1987; +Cc: fstests, guaneryu, linux-xfs, Kaixu Xia
On Mon, Dec 07, 2020 at 07:41:05PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The mount options uqnoenforce and qnoenforce no longer cause 'usrquota'
> to be emitted in /proc/mounts, so there is a regression in xfs/513. Fix
> it by using proper output option uqnoenforce.
>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Seems reasonable once the upstream change gets a commit id so that we
can point people at how to fix this new regression.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/513 | 4 ++--
> tests/xfs/513.out | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/xfs/513 b/tests/xfs/513
> index dfb25a8b..9045dbb5 100755
> --- a/tests/xfs/513
> +++ b/tests/xfs/513
> @@ -302,8 +302,8 @@ do_test "" pass "usrquota" "false"
> do_test "-o uquota" pass "usrquota" "true"
> do_test "-o usrquota" pass "usrquota" "true"
> do_test "-o quota" pass "usrquota" "true"
> -do_test "-o uqnoenforce" pass "usrquota" "true"
> -do_test "-o qnoenforce" pass "usrquota" "true"
> +do_test "-o uqnoenforce" pass "uqnoenforce" "true"
> +do_test "-o qnoenforce" pass "uqnoenforce" "true"
>
> # Test gquota/grpquota/gqnoenforce
> do_test "" pass "grpquota" "false"
> diff --git a/tests/xfs/513.out b/tests/xfs/513.out
> index 6681a7e8..eec8155d 100644
> --- a/tests/xfs/513.out
> +++ b/tests/xfs/513.out
> @@ -76,8 +76,8 @@ TEST: "" "pass" "usrquota" "false"
> TEST: "-o uquota" "pass" "usrquota" "true"
> TEST: "-o usrquota" "pass" "usrquota" "true"
> TEST: "-o quota" "pass" "usrquota" "true"
> -TEST: "-o uqnoenforce" "pass" "usrquota" "true"
> -TEST: "-o qnoenforce" "pass" "usrquota" "true"
> +TEST: "-o uqnoenforce" "pass" "uqnoenforce" "true"
> +TEST: "-o qnoenforce" "pass" "uqnoenforce" "true"
> TEST: "" "pass" "grpquota" "false"
> TEST: "-o gquota" "pass" "grpquota" "true"
> TEST: "-o grpquota" "pass" "grpquota" "true"
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-07 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 11:41 [PATCH] xfs/513: fix the regression caused by mount option uqnoenforce xiakaixu1987
2020-12-07 17:01 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).