From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: rename xfs_fc_* back to xfs_fs_*
Date: Mon, 7 Dec 2020 12:46:29 -0500 [thread overview]
Message-ID: <20201207174629.GE1598552@bfoster> (raw)
In-Reply-To: <160729627541.1608297.18095324548384560045.stgit@magnolia>
On Sun, Dec 06, 2020 at 03:11:15PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Get rid of this one-off namespace since we're done converting things to
> fscontext now.
>
> Suggested-by: Dave Chinner <david@fromorbit.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_super.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 36002f460d7c..12d6850aedc6 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1159,7 +1159,7 @@ suffix_kstrtoint(
> * NOTE: mp->m_super is NULL here!
> */
> static int
> -xfs_fc_parse_param(
> +xfs_fs_parse_param(
> struct fs_context *fc,
> struct fs_parameter *param)
> {
> @@ -1317,7 +1317,7 @@ xfs_fc_parse_param(
> }
>
> static int
> -xfs_fc_validate_params(
> +xfs_fs_validate_params(
> struct xfs_mount *mp)
> {
> /*
> @@ -1386,7 +1386,7 @@ xfs_fc_validate_params(
> }
>
> static int
> -xfs_fc_fill_super(
> +xfs_fs_fill_super(
> struct super_block *sb,
> struct fs_context *fc)
> {
> @@ -1396,7 +1396,7 @@ xfs_fc_fill_super(
>
> mp->m_super = sb;
>
> - error = xfs_fc_validate_params(mp);
> + error = xfs_fs_validate_params(mp);
> if (error)
> goto out_free_names;
>
> @@ -1660,10 +1660,10 @@ xfs_fc_fill_super(
> }
>
> static int
> -xfs_fc_get_tree(
> +xfs_fs_get_tree(
> struct fs_context *fc)
> {
> - return get_tree_bdev(fc, xfs_fc_fill_super);
> + return get_tree_bdev(fc, xfs_fs_fill_super);
> }
>
> static int
> @@ -1782,7 +1782,7 @@ xfs_remount_ro(
> * silently ignore all options that we can't actually change.
> */
> static int
> -xfs_fc_reconfigure(
> +xfs_fs_reconfigure(
> struct fs_context *fc)
> {
> struct xfs_mount *mp = XFS_M(fc->root->d_sb);
> @@ -1795,7 +1795,7 @@ xfs_fc_reconfigure(
> if (XFS_SB_VERSION_NUM(&mp->m_sb) == XFS_SB_VERSION_5)
> fc->sb_flags |= SB_I_VERSION;
>
> - error = xfs_fc_validate_params(new_mp);
> + error = xfs_fs_validate_params(new_mp);
> if (error)
> return error;
>
> @@ -1832,7 +1832,7 @@ xfs_fc_reconfigure(
> return 0;
> }
>
> -static void xfs_fc_free(
> +static void xfs_fs_free(
> struct fs_context *fc)
> {
> struct xfs_mount *mp = fc->s_fs_info;
> @@ -1848,10 +1848,10 @@ static void xfs_fc_free(
> }
>
> static const struct fs_context_operations xfs_context_ops = {
> - .parse_param = xfs_fc_parse_param,
> - .get_tree = xfs_fc_get_tree,
> - .reconfigure = xfs_fc_reconfigure,
> - .free = xfs_fc_free,
> + .parse_param = xfs_fs_parse_param,
> + .get_tree = xfs_fs_get_tree,
> + .reconfigure = xfs_fs_reconfigure,
> + .free = xfs_fs_free,
> };
>
> static int xfs_init_fs_context(
>
prev parent reply other threads:[~2020-12-07 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 23:10 [PATCH 0/4] xfs: refactor extent validation for 5.11 Darrick J. Wong
2020-12-06 23:10 ` [PATCH 1/4] xfs: refactor data device extent validation Darrick J. Wong
2020-12-06 23:49 ` Dave Chinner
2020-12-07 14:15 ` Christoph Hellwig
2020-12-07 17:46 ` Brian Foster
2020-12-06 23:11 ` [PATCH 2/4] xfs: refactor realtime volume " Darrick J. Wong
2020-12-06 23:51 ` Dave Chinner
2020-12-07 14:16 ` Christoph Hellwig
2020-12-07 17:46 ` Brian Foster
2020-12-06 23:11 ` [PATCH 3/4] xfs: refactor file range validation Darrick J. Wong
2020-12-06 23:56 ` Dave Chinner
2020-12-07 14:17 ` Christoph Hellwig
2020-12-07 17:46 ` Brian Foster
2020-12-06 23:11 ` [PATCH 4/4] xfs: rename xfs_fc_* back to xfs_fs_* Darrick J. Wong
2020-12-06 23:56 ` Dave Chinner
2020-12-07 14:17 ` Christoph Hellwig
2020-12-07 17:46 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207174629.GE1598552@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).