linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* assertation failures in generic/388
@ 2021-01-18 19:25 Christoph Hellwig
  2021-01-18 20:01 ` Brian Foster
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-01-18 19:25 UTC (permalink / raw)
  To: linux-xfs

Hi all,

latest Linus' tree crashes every few runs for me when running on x86_64,
4k block size, virtio-blk, CONFIG_XFS_DEBUG enabled:

Dmesg:
[   93.950923] XFS: Assertion failed: percpu_counter_compare(&mp->m_ifree, 0) >5
[   93.953038] ------------[ cut here ]------------
[   93.953688] kernel BUG at fs/xfs/xfs_message.c:110!
[   93.954960] invalid opcode: 0000 [#1] PREEMPT SMP PTI
[   93.955765] CPU: 2 PID: 5064 Comm: fsstress Not tainted 5.11.0-rc4 #445
[   93.956857] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.144
[   93.958310] RIP: 0010:assfail+0x1e/0x23
[   93.958912] Code: a0 87 04 83 e8 85 fc ff ff 0f 0b c3 41 89 c8 48 89 d1 48 84
[   93.962114] RSP: 0018:ffffc90002dc3a40 EFLAGS: 00010202
[   93.962828] RAX: 0000000000000000 RBX: ffff88810ce39000 RCX: 0000000000000000
[   93.963809] RDX: 00000000ffffffc0 RSI: 0000000000000000 RDI: ffffffff82fb4471
[   93.964799] RBP: ffff88810d7d0258 R08: 0000000000000000 R09: 000000000000000a
[   93.965764] R10: 000000000000000a R11: f000000000000000 R12: 0000000000000000
[   93.966698] R13: ffff88810ce39520 R14: ffffffffffffffff R15: ffff88810d7d0310
[   93.967593] FS:  00007fd84a28db80(0000) GS:ffff88813bd00000(0000) knlGS:00000
[   93.968605] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   93.969354] CR2: 00007fd84a492000 CR3: 000000010d7da000 CR4: 00000000000006e0
[   93.970290] Call Trace:
[   93.970607]  xfs_trans_unreserve_and_mod_sb+0x1ed/0x270
[   93.971423]  xfs_log_commit_cil+0x598/0xac0
[   93.972222]  __xfs_trans_commit+0xbe/0x3e0
[   93.972820]  xfs_create+0x551/0x630
[   93.973333]  xfs_generic_create+0x240/0x320
[   93.973941]  ? d_splice_alias+0x169/0x490
[   93.974473]  lookup_open.isra.0+0x2da/0x610
[   93.975011]  path_openat+0x261/0x920
[   93.975466]  do_filp_open+0x83/0x130
[   93.975922]  ? _raw_spin_unlock+0x24/0x40
[   93.976434]  ? alloc_fd+0xf1/0x1e0
[   93.976917]  do_sys_openat2+0x92/0x150
[   93.977558]  __x64_sys_creat+0x44/0x60
[   93.978125]  do_syscall_64+0x33/0x40
[   93.978585]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   93.979241] RIP: 0033:0x7fd84a379cc4
[   93.979717] Code: 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 4c
[   93.982051] RSP: 002b:00007ffe6f490268 EFLAGS: 00000246 ORIG_RAX: 00000000005
[   93.983068] RAX: ffffffffffffffda RBX: 0000000000000047 RCX: 00007fd84a379cc4
[   93.984079] RDX: 0000000000000000 RSI: 00000000000001b6 RDI: 0000559463b37ff0
[   93.984993] RBP: 00007ffe6f4903d0 R08: fefefefefefefeff R09: fefeff36ff603365
[   93.985916] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000000001b6
[   93.986935] R13: 0000000000000001 R14: 00007ffe6f490470 R15: 00005594625041c0
[   93.987971] Modules linked in:


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: assertation failures in generic/388
  2021-01-18 19:25 assertation failures in generic/388 Christoph Hellwig
@ 2021-01-18 20:01 ` Brian Foster
  2021-01-19  7:28   ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Foster @ 2021-01-18 20:01 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-xfs

On Mon, Jan 18, 2021 at 07:25:47PM +0000, Christoph Hellwig wrote:
> Hi all,
> 
> latest Linus' tree crashes every few runs for me when running on x86_64,
> 4k block size, virtio-blk, CONFIG_XFS_DEBUG enabled:
> 
> Dmesg:
> [   93.950923] XFS: Assertion failed: percpu_counter_compare(&mp->m_ifree, 0) >5

This is likely fixed by the first patch [1] in my log covering rework
series. generic/388 was recently modified to reproduce.

Brian

[1] https://lore.kernel.org/linux-xfs/20210106174127.805660-2-bfoster@redhat.com/

> [   93.953038] ------------[ cut here ]------------
> [   93.953688] kernel BUG at fs/xfs/xfs_message.c:110!
> [   93.954960] invalid opcode: 0000 [#1] PREEMPT SMP PTI
> [   93.955765] CPU: 2 PID: 5064 Comm: fsstress Not tainted 5.11.0-rc4 #445
> [   93.956857] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.144
> [   93.958310] RIP: 0010:assfail+0x1e/0x23
> [   93.958912] Code: a0 87 04 83 e8 85 fc ff ff 0f 0b c3 41 89 c8 48 89 d1 48 84
> [   93.962114] RSP: 0018:ffffc90002dc3a40 EFLAGS: 00010202
> [   93.962828] RAX: 0000000000000000 RBX: ffff88810ce39000 RCX: 0000000000000000
> [   93.963809] RDX: 00000000ffffffc0 RSI: 0000000000000000 RDI: ffffffff82fb4471
> [   93.964799] RBP: ffff88810d7d0258 R08: 0000000000000000 R09: 000000000000000a
> [   93.965764] R10: 000000000000000a R11: f000000000000000 R12: 0000000000000000
> [   93.966698] R13: ffff88810ce39520 R14: ffffffffffffffff R15: ffff88810d7d0310
> [   93.967593] FS:  00007fd84a28db80(0000) GS:ffff88813bd00000(0000) knlGS:00000
> [   93.968605] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   93.969354] CR2: 00007fd84a492000 CR3: 000000010d7da000 CR4: 00000000000006e0
> [   93.970290] Call Trace:
> [   93.970607]  xfs_trans_unreserve_and_mod_sb+0x1ed/0x270
> [   93.971423]  xfs_log_commit_cil+0x598/0xac0
> [   93.972222]  __xfs_trans_commit+0xbe/0x3e0
> [   93.972820]  xfs_create+0x551/0x630
> [   93.973333]  xfs_generic_create+0x240/0x320
> [   93.973941]  ? d_splice_alias+0x169/0x490
> [   93.974473]  lookup_open.isra.0+0x2da/0x610
> [   93.975011]  path_openat+0x261/0x920
> [   93.975466]  do_filp_open+0x83/0x130
> [   93.975922]  ? _raw_spin_unlock+0x24/0x40
> [   93.976434]  ? alloc_fd+0xf1/0x1e0
> [   93.976917]  do_sys_openat2+0x92/0x150
> [   93.977558]  __x64_sys_creat+0x44/0x60
> [   93.978125]  do_syscall_64+0x33/0x40
> [   93.978585]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> [   93.979241] RIP: 0033:0x7fd84a379cc4
> [   93.979717] Code: 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 4c
> [   93.982051] RSP: 002b:00007ffe6f490268 EFLAGS: 00000246 ORIG_RAX: 00000000005
> [   93.983068] RAX: ffffffffffffffda RBX: 0000000000000047 RCX: 00007fd84a379cc4
> [   93.984079] RDX: 0000000000000000 RSI: 00000000000001b6 RDI: 0000559463b37ff0
> [   93.984993] RBP: 00007ffe6f4903d0 R08: fefefefefefefeff R09: fefeff36ff603365
> [   93.985916] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000000001b6
> [   93.986935] R13: 0000000000000001 R14: 00007ffe6f490470 R15: 00005594625041c0
> [   93.987971] Modules linked in:
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: assertation failures in generic/388
  2021-01-18 20:01 ` Brian Foster
@ 2021-01-19  7:28   ` Christoph Hellwig
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-01-19  7:28 UTC (permalink / raw)
  To: Brian Foster; +Cc: Christoph Hellwig, linux-xfs

On Mon, Jan 18, 2021 at 03:01:23PM -0500, Brian Foster wrote:
> On Mon, Jan 18, 2021 at 07:25:47PM +0000, Christoph Hellwig wrote:
> > Hi all,
> > 
> > latest Linus' tree crashes every few runs for me when running on x86_64,
> > 4k block size, virtio-blk, CONFIG_XFS_DEBUG enabled:
> > 
> > Dmesg:
> > [   93.950923] XFS: Assertion failed: percpu_counter_compare(&mp->m_ifree, 0) >5
> 
> This is likely fixed by the first patch [1] in my log covering rework
> series. generic/388 was recently modified to reproduce.

Would be great if we could push the fix to mainline and -stable then.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-19  7:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 19:25 assertation failures in generic/388 Christoph Hellwig
2021-01-18 20:01 ` Brian Foster
2021-01-19  7:28   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).