From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: pass struct xfs_eofblocks to the inode scan callback
Date: Wed, 24 Mar 2021 11:03:22 -0700 [thread overview]
Message-ID: <20210324180322.GY22100@magnolia> (raw)
In-Reply-To: <20210324070307.908462-4-hch@lst.de>
On Wed, Mar 24, 2021 at 08:03:07AM +0100, Christoph Hellwig wrote:
> Pass the actual structure instead of a void pointer here now
> that none of the functions is used as a callback.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> xfs_inode_free_cowblocks(
Assuming this ends up fitting in somewhere,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_icache.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 7fdf77df66269c..06286b5b613252 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -763,7 +763,7 @@ xfs_inode_walk_ag_grab(
> static int
> xfs_blockgc_scan_inode(
> struct xfs_inode *ip,
> - void *args);
> + struct xfs_eofblocks *eofb);
>
> /*
> * For a given per-AG structure @pag, grab, @execute, and rele all incore
> @@ -1228,10 +1228,9 @@ xfs_reclaim_worker(
> STATIC int
> xfs_inode_free_eofblocks(
> struct xfs_inode *ip,
> - void *args,
> + struct xfs_eofblocks *eofb,
> unsigned int *lockflags)
> {
> - struct xfs_eofblocks *eofb = args;
> bool wait;
>
> wait = eofb && (eofb->eof_flags & XFS_EOF_FLAGS_SYNC);
> @@ -1436,10 +1435,9 @@ xfs_prep_free_cowblocks(
> STATIC int
> xfs_inode_free_cowblocks(
> struct xfs_inode *ip,
> - void *args,
> + struct xfs_eofblocks *eofb,
> unsigned int *lockflags)
> {
> - struct xfs_eofblocks *eofb = args;
> bool wait;
> int ret = 0;
>
> @@ -1534,16 +1532,16 @@ xfs_blockgc_start(
> static int
> xfs_blockgc_scan_inode(
> struct xfs_inode *ip,
> - void *args)
> + struct xfs_eofblocks *eofb)
> {
> unsigned int lockflags = 0;
> int error;
>
> - error = xfs_inode_free_eofblocks(ip, args, &lockflags);
> + error = xfs_inode_free_eofblocks(ip, eofb, &lockflags);
> if (error)
> goto unlock;
>
> - error = xfs_inode_free_cowblocks(ip, args, &lockflags);
> + error = xfs_inode_free_cowblocks(ip, eofb, &lockflags);
> unlock:
> if (lockflags)
> xfs_iunlock(ip, lockflags);
> --
> 2.30.1
>
prev parent reply other threads:[~2021-03-24 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:03 simplify the blockgc iwalk infrastructure Christoph Hellwig
2021-03-24 7:03 ` [PATCH 1/3] xfs: use s_inodes in xfs_qm_dqrele_all_inodes Christoph Hellwig
2021-03-24 17:50 ` Darrick J. Wong
2021-03-24 7:03 ` [PATCH 2/3] xfs: simplify the perage inode walk infrastructure Christoph Hellwig
2021-03-24 17:57 ` Darrick J. Wong
2021-03-24 17:59 ` Christoph Hellwig
2021-03-25 4:30 ` Darrick J. Wong
2021-03-24 7:03 ` [PATCH 3/3] xfs: pass struct xfs_eofblocks to the inode scan callback Christoph Hellwig
2021-03-24 18:03 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324180322.GY22100@magnolia \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).