From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: simplify the perage inode walk infrastructure
Date: Wed, 24 Mar 2021 21:30:45 -0700 [thread overview]
Message-ID: <20210325043045.GD4090233@magnolia> (raw)
In-Reply-To: <20210324175937.GA14862@lst.de>
On Wed, Mar 24, 2021 at 06:59:37PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 24, 2021 at 10:57:35AM -0700, Darrick J. Wong wrote:
> > On Wed, Mar 24, 2021 at 08:03:06AM +0100, Christoph Hellwig wrote:
> > > Remove the generic xfs_inode_walk and just open code the only caller.
> >
> > This is going in the wrong direction for me. Maybe.
> >
> > I was planning to combine the reclaim inode walk into this function, and
> > later on share it with inactivation. This made for one switch-happy
> > iteration function, but it meant there was only one loop.
>
> Ok, we can skip this for now if this gets in your way. Or I can resend
> a different patch 2 that just removes the no tag case for now.
>
> > OFC maybe the point that you and/or Dave were trying to make is that I
> > should be doing the opposite, and combining the inactivation loop into
> > what is now the (badly misnamed) xfs_reclaim_inodes_ag? And leave this
> > blockgc loop alone?
>
> That is my gut feeling. No guarantee it actually works out, and given
> that I've lead you down the wrong road a few times I already feel guily
> ahead of time..
Actually, collapsing all of the tag walkers into xfs_inode_walk was
pretty straightforward, and in the end I just borrowed bits and pieces
from patches 2 and 3 to make it happen and clean up the arguments. The
net change is 55 lines deleted and ~1k less code (granted with all the
debugging and ubsan crud turned on).
--D
next prev parent reply other threads:[~2021-03-25 4:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:03 simplify the blockgc iwalk infrastructure Christoph Hellwig
2021-03-24 7:03 ` [PATCH 1/3] xfs: use s_inodes in xfs_qm_dqrele_all_inodes Christoph Hellwig
2021-03-24 17:50 ` Darrick J. Wong
2021-03-24 7:03 ` [PATCH 2/3] xfs: simplify the perage inode walk infrastructure Christoph Hellwig
2021-03-24 17:57 ` Darrick J. Wong
2021-03-24 17:59 ` Christoph Hellwig
2021-03-25 4:30 ` Darrick J. Wong [this message]
2021-03-24 7:03 ` [PATCH 3/3] xfs: pass struct xfs_eofblocks to the inode scan callback Christoph Hellwig
2021-03-24 18:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325043045.GD4090233@magnolia \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).