* [PATCH] xfs: fix warnings in compat_ioctl code
@ 2021-07-03 3:01 Darrick J. Wong
2021-07-05 8:43 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2021-07-03 3:01 UTC (permalink / raw)
To: xfs
From: Darrick J. Wong <djwong@kernel.org>
Fix some compiler warnings about unused variables.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/xfs_ioctl32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
index e6506773ba55..ebcc342e3bf8 100644
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -439,7 +439,6 @@ xfs_file_compat_ioctl(
struct inode *inode = file_inode(filp);
struct xfs_inode *ip = XFS_I(inode);
void __user *arg = compat_ptr(p);
- int error;
trace_xfs_file_compat_ioctl(ip);
@@ -460,6 +459,7 @@ xfs_file_compat_ioctl(
return xfs_compat_ioc_fsgeometry_v1(ip->i_mount, arg);
case XFS_IOC_FSGROWFSDATA_32: {
struct xfs_growfs_data in;
+ int error;
if (xfs_compat_growfs_data_copyin(&in, arg))
return -EFAULT;
@@ -472,6 +472,7 @@ xfs_file_compat_ioctl(
}
case XFS_IOC_FSGROWFSRT_32: {
struct xfs_growfs_rt in;
+ int error;
if (xfs_compat_growfs_rt_copyin(&in, arg))
return -EFAULT;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fix warnings in compat_ioctl code
2021-07-03 3:01 [PATCH] xfs: fix warnings in compat_ioctl code Darrick J. Wong
@ 2021-07-05 8:43 ` Christoph Hellwig
2021-07-06 17:19 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-07-05 8:43 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On Fri, Jul 02, 2021 at 08:01:20PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix some compiler warnings about unused variables.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
The change looks silly but otherwise ok. What compiler gives these
stupid warnings?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: fix warnings in compat_ioctl code
2021-07-05 8:43 ` Christoph Hellwig
@ 2021-07-06 17:19 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2021-07-06 17:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Mon, Jul 05, 2021 at 09:43:20AM +0100, Christoph Hellwig wrote:
> On Fri, Jul 02, 2021 at 08:01:20PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Fix some compiler warnings about unused variables.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> The change looks silly but otherwise ok. What compiler gives these
> stupid warnings?
gcc 10.3, but it doesn't matter because the kbuild robot says this patch
creates even /more/ silly warnings on other weird architectures, so I'm
withdrawing this patch because I DGAF^W have decided that chasing unused
variable warnings is a bad use of anybody's time.
--D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-06 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 3:01 [PATCH] xfs: fix warnings in compat_ioctl code Darrick J. Wong
2021-07-05 8:43 ` Christoph Hellwig
2021-07-06 17:19 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).