From: Carlos Maiolino <cmaiolino@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk
Date: Wed, 14 Jul 2021 13:11:38 +0200 [thread overview]
Message-ID: <20210714111138.4vd6s4ukncx7zb6s@omega.lan> (raw)
In-Reply-To: <20210712111426.83004-3-hch@lst.de>
On Mon, Jul 12, 2021 at 01:14:25PM +0200, Christoph Hellwig wrote:
> We always purge all dquots now, so drop the argument.
>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_qm.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 580b9dba21122b..2b34273d0405e7 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -187,15 +187,11 @@ xfs_qm_dqpurge(
> */
> static void
> xfs_qm_dqpurge_all(
> - struct xfs_mount *mp,
> - uint flags)
> + struct xfs_mount *mp)
> {
> - if (flags & XFS_QMOPT_UQUOTA)
> - xfs_qm_dquot_walk(mp, XFS_DQTYPE_USER, xfs_qm_dqpurge, NULL);
> - if (flags & XFS_QMOPT_GQUOTA)
> - xfs_qm_dquot_walk(mp, XFS_DQTYPE_GROUP, xfs_qm_dqpurge, NULL);
> - if (flags & XFS_QMOPT_PQUOTA)
> - xfs_qm_dquot_walk(mp, XFS_DQTYPE_PROJ, xfs_qm_dqpurge, NULL);
> + xfs_qm_dquot_walk(mp, XFS_DQTYPE_USER, xfs_qm_dqpurge, NULL);
> + xfs_qm_dquot_walk(mp, XFS_DQTYPE_GROUP, xfs_qm_dqpurge, NULL);
> + xfs_qm_dquot_walk(mp, XFS_DQTYPE_PROJ, xfs_qm_dqpurge, NULL);
> }
>
> /*
> @@ -206,7 +202,7 @@ xfs_qm_unmount(
> struct xfs_mount *mp)
> {
> if (mp->m_quotainfo) {
> - xfs_qm_dqpurge_all(mp, XFS_QMOPT_QUOTALL);
> + xfs_qm_dqpurge_all(mp);
> xfs_qm_destroy_quotainfo(mp);
> }
> }
> @@ -1359,7 +1355,7 @@ xfs_qm_quotacheck(
> * at this point (because we intentionally didn't in dqget_noattach).
> */
> if (error) {
> - xfs_qm_dqpurge_all(mp, XFS_QMOPT_QUOTALL);
> + xfs_qm_dqpurge_all(mp);
> goto error_return;
> }
>
> --
> 2.30.2
>
--
Carlos
next prev parent reply other threads:[~2021-07-14 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:14 don't allow disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-12 11:14 ` [PATCH 1/3] xfs: remove support for " Christoph Hellwig
2021-07-14 11:10 ` Carlos Maiolino
2021-07-20 6:33 ` Christoph Hellwig
2021-07-14 21:44 ` Darrick J. Wong
2021-07-15 17:15 ` Darrick J. Wong
2021-07-20 6:35 ` Christoph Hellwig
2021-07-12 11:14 ` [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk Christoph Hellwig
2021-07-14 11:11 ` Carlos Maiolino [this message]
2021-07-14 21:45 ` Darrick J. Wong
2021-07-12 11:14 ` [PATCH 3/3] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-07-14 11:47 ` Carlos Maiolino
2021-07-14 21:47 ` Darrick J. Wong
2021-07-22 7:26 don't allow disabling quota accounting on a mounted file system v2 Christoph Hellwig
2021-07-22 7:26 ` [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714111138.4vd6s4ukncx7zb6s@omega.lan \
--to=cmaiolino@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).