Re: don't allow disabling quota accounting on a mounted file system v2

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 09, 2021 at 08:59:34AM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> disabling quota accounting (vs just enforcement) on a running file system
> is a fundamentally race and hard to get right operation.  It also has
> very little practical use.
> 
> Note that the quotaitem log recovery code is left for to make sure we
> don't introduce inconsistent recovery states.
> 
> A series has been sent to make xfstests cope with this feature removal.
> 
> Changes since v1:
>  - fix a spelling mistake
>  - add a new patch to remove xfs_dqrele_all_inodes

Applied, thanks.

FWIW this matches 100% the patches that I had scooped up from the v1
series a week ago as a prerequisite for deferred inactivation, so
everything looks good from this end.

--D

> 
> Diffstat:
>  libxfs/xfs_quota_defs.h |   30 -----
>  libxfs/xfs_trans_resv.c |   30 -----
>  libxfs/xfs_trans_resv.h |    2 
>  scrub/quota.c           |    2 
>  xfs_dquot.c             |    3 
>  xfs_dquot_item.c        |  134 --------------------------
>  xfs_dquot_item.h        |   17 ---
>  xfs_icache.c            |  107 ---------------------
>  xfs_icache.h            |    6 -
>  xfs_ioctl.c             |    2 
>  xfs_iops.c              |    4 
>  xfs_mount.c             |    4 
>  xfs_qm.c                |   44 +++-----
>  xfs_qm.h                |    3 
>  xfs_qm_syscalls.c       |  243 ++----------------------------------------------
>  xfs_quotaops.c          |   30 +----
>  xfs_super.c             |   51 ++++------
>  xfs_trans_dquot.c       |   49 ---------
>  18 files changed, 78 insertions(+), 683 deletions(-)