From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] iomap: standardize tracepoint formatting and storage
Date: Tue, 24 Aug 2021 08:08:13 +1000 [thread overview]
Message-ID: <20210823220813.GJ3657114@dread.disaster.area> (raw)
In-Reply-To: <20210822023223.GY12640@magnolia>
On Sat, Aug 21, 2021 at 07:32:23PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Print all the offset, pos, and length quantities in hexadecimal. While
> we're at it, update the types of the tracepoint structure fields to
> match the types of the values being recorded in them.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/iomap/trace.h | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
Looks good. That will help when mixed with XFS tracepoints :)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2021-08-23 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 2:32 [PATCH] iomap: standardize tracepoint formatting and storage Darrick J. Wong
2021-08-22 3:30 ` Matthew Wilcox
2021-08-22 17:20 ` Darrick J. Wong
2021-08-23 7:05 ` Christoph Hellwig
2021-08-23 7:03 ` Christoph Hellwig
2021-08-23 22:08 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823220813.GJ3657114@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).