From: Bill O'Donnell <billodo@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Bill O'Donnell <bodonnel@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: dax: facilitate EXPERIMENTAL warning for dax=inode case
Date: Mon, 30 Aug 2021 10:55:19 -0500 [thread overview]
Message-ID: <20210830155519.b3ddh66dve4xcfgq@redhat.com> (raw)
In-Reply-To: <20210826180947.GL12640@magnolia>
On Thu, Aug 26, 2021 at 11:09:47AM -0700, Darrick J. Wong wrote:
> On Thu, Aug 26, 2021 at 12:30:12PM -0500, Bill O'Donnell wrote:
> > When dax-mode was tri-stated by adding dax=inode case, the EXPERIMENTAL
> > warning on mount was missed for the case. Add logic to handle the
> > warning similar to that of the 'dax=always' case.
> >
> > Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
> > ---
> > fs/xfs/xfs_mount.h | 2 ++
> > fs/xfs/xfs_super.c | 8 +++++---
> > 2 files changed, 7 insertions(+), 3 deletions(-)
...
> > - if (xfs_has_dax_always(mp)) {
> > + if (xfs_has_dax_always(mp) || xfs_has_dax_inode(mp)) {
>
> Er... can't this be done without burning another feature bit by:
>
> if (xfs_has_dax_always(mp) || (!xfs_has_dax_always(mp) &&
> !xfs_has_dax_never(mp))) {
> ...
> xfs_warn(mp, "DAX IS EXPERIMENTAL");
> }
Not quite. This will be true at initialization.
-Bill
prev parent reply other threads:[~2021-08-30 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 17:30 [PATCH] xfs: dax: facilitate EXPERIMENTAL warning for dax=inode case Bill O'Donnell
2021-08-26 18:09 ` Darrick J. Wong
2021-08-26 18:14 ` Bill O'Donnell
2021-08-26 18:16 ` Eric Sandeen
2021-08-26 22:08 ` Bill O'Donnell
2021-08-26 23:43 ` Eric Sandeen
2021-08-27 14:03 ` Bill O'Donnell
2021-08-27 14:18 ` Eric Sandeen
2021-08-27 14:25 ` Bill O'Donnell
2021-08-27 15:35 ` Eric Sandeen
2021-08-27 15:41 ` Bill O'Donnell
2021-08-30 15:55 ` Bill O'Donnell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830155519.b3ddh66dve4xcfgq@redhat.com \
--to=billodo@redhat.com \
--cc=bodonnel@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).