* Patch "iomap: pass writeback errors to the mapping" has been added to the 5.14-stable tree
@ 2021-09-16 11:34 Sasha Levin
0 siblings, 0 replies; only message in thread
From: Sasha Levin @ 2021-09-16 11:34 UTC (permalink / raw)
To: stable-commits, djwong
Cc: Christoph Hellwig, Darrick J. Wong, linux-xfs, linux-fsdevel
This is a note to let you know that I've just added the patch titled
iomap: pass writeback errors to the mapping
to the 5.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iomap-pass-writeback-errors-to-the-mapping.patch
and it can be found in the queue-5.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
commit 140bbef57113ae67aea10307f03bb925df8589d5
Author: Darrick J. Wong <djwong@kernel.org>
Date: Tue Aug 10 18:32:55 2021 -0700
iomap: pass writeback errors to the mapping
[ Upstream commit b69eea82d37d9ee7cfb3bf05103549dd4ed5ffc3 ]
Modern-day mapping_set_error has the ability to squash the usual
negative error code into something appropriate for long-term storage in
a struct address_space -- ENOSPC becomes AS_ENOSPC, and everything else
becomes EIO. iomap squashes /everything/ to EIO, just as XFS did before
that, but this doesn't make sense.
Fix this by making it so that we can pass ENOSPC to userspace when
writeback fails due to space problems.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 87ccb3438bec..b06138c6190b 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1016,7 +1016,7 @@ iomap_finish_page_writeback(struct inode *inode, struct page *page,
if (error) {
SetPageError(page);
- mapping_set_error(inode->i_mapping, -EIO);
+ mapping_set_error(inode->i_mapping, error);
}
WARN_ON_ONCE(i_blocks_per_page(inode, page) > 1 && !iop);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-16 11:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 11:34 Patch "iomap: pass writeback errors to the mapping" has been added to the 5.14-stable tree Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).