From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/5] populate: require e2image before populating
Date: Thu, 13 Oct 2022 23:48:33 +0800 [thread overview]
Message-ID: <20221013154833.kqwygzftf7thscx7@zlang-mailbox> (raw)
In-Reply-To: <166553914474.422450.8871747567060992809.stgit@magnolia>
On Tue, Oct 11, 2022 at 06:45:44PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Use $E2IMAGE_PROG, not e2image, and check that it exists before
> proceeding.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
Make sense,
Reviewed-by: Zorro Lang <zlang@redhat.com>
> common/populate | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> diff --git a/common/populate b/common/populate
> index 66c55b682f..05bdfe33c5 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -18,6 +18,7 @@ _require_populate_commands() {
> ;;
> ext*)
> _require_command "$DUMPE2FS_PROG" "dumpe2fs"
> + _require_command "$E2IMAGE_PROG" "e2image"
> ;;
> esac
> }
> @@ -874,7 +875,7 @@ _scratch_populate_restore_cached() {
> return $res
> ;;
> "ext2"|"ext3"|"ext4")
> - e2image -r "${metadump}" "${SCRATCH_DEV}"
> + $E2IMAGE_PROG -r "${metadump}" "${SCRATCH_DEV}"
> ret=$?
> test $ret -ne 0 && return $ret
>
>
next prev parent reply other threads:[~2022-10-13 15:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 1:45 [PATCHSET 0/5] fstests: support external logs when caching prepopulated images Darrick J. Wong
2022-10-12 1:45 ` [PATCH 1/5] populate: export the metadump description name Darrick J. Wong
2022-10-13 14:55 ` Zorro Lang
2022-10-13 15:54 ` Darrick J. Wong
2022-10-13 16:28 ` Zorro Lang
2022-10-13 19:12 ` Darrick J. Wong
2022-10-14 1:17 ` Zorro Lang
2022-10-14 18:21 ` [PATCH v1.1 " Darrick J. Wong
2022-10-15 5:01 ` Zorro Lang
2022-10-15 5:10 ` Zorro Lang
2022-10-15 7:28 ` Darrick J. Wong
2022-10-15 8:21 ` Zorro Lang
2022-10-15 7:23 ` Darrick J. Wong
2022-10-12 1:45 ` [PATCH 2/5] populate: wipe external xfs log devices when restoring a cached image Darrick J. Wong
2022-10-13 15:10 ` Zorro Lang
2022-10-12 1:45 ` [PATCH 3/5] populate: reformat external ext[34] journal " Darrick J. Wong
2022-10-13 15:47 ` Zorro Lang
2022-10-12 1:45 ` [PATCH 4/5] populate: require e2image before populating Darrick J. Wong
2022-10-13 15:48 ` Zorro Lang [this message]
2022-10-12 1:45 ` [PATCH 5/5] fstests: refactor xfs_mdrestore calls Darrick J. Wong
2022-10-13 16:06 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013154833.kqwygzftf7thscx7@zlang-mailbox \
--to=zlang@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).