From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/5] populate: export the metadump description name
Date: Fri, 14 Oct 2022 09:17:41 +0800 [thread overview]
Message-ID: <20221014011741.ky4bml5ythuv3svb@zlang-mailbox> (raw)
In-Reply-To: <Y0hjE3neN2rDhkxw@magnolia>
On Thu, Oct 13, 2022 at 12:12:19PM -0700, Darrick J. Wong wrote:
> On Fri, Oct 14, 2022 at 12:28:26AM +0800, Zorro Lang wrote:
> > On Thu, Oct 13, 2022 at 08:54:35AM -0700, Darrick J. Wong wrote:
> > > On Thu, Oct 13, 2022 at 10:55:15PM +0800, Zorro Lang wrote:
> > > > On Tue, Oct 11, 2022 at 06:45:27PM -0700, Darrick J. Wong wrote:
> > > > > From: Darrick J. Wong <djwong@kernel.org>
> > > > >
> > > > > Not sure why this hasn't been broken all along, but we should be
> > > > > exporting this variable so that it shows up in subshells....
> > > >
> > > > May I ask where's the subshell which uses $POPULATE_METADUMP?
> > >
> > > _scratch_xfs_fuzz_metadata does this:
> > >
> > > echo "${fields}" | while read field; do
> > > echo "${verbs}" | while read fuzzverb; do
> > > __scratch_xfs_fuzz_mdrestore
> > > _xfs_mdrestore "${POPULATE_METADUMP}"
> > >
> > > The (nested) echo piped to while starts subshells.
> >
> > I'm not so familar with this part, so I didn't a simple test[1], and looks like
> > the PARAM can be seen, even it's not exported. Do I misunderstand something?
> >
> > Thanks,
> > Zorro
> >
> > [1]
> > $ echo "$list"
> > a
> > b
> > cc
> > $ PARAM="This's a test"
> > $ echo "$list"|while read c1;do echo "$list"|while read c2;do echo $PARAM;done; done
> > This's a test
> > This's a test
> > This's a test
> > This's a test
> > This's a test
> > This's a test
> > This's a test
> > This's a test
> > This's a test
>
> Hmm. I can't figure out why I needed the export here. It was late one
> night, something was broken, and exporting the variable made it work.
> Now I can't recall exactly what that was and it seems fine without
> it...?
>
> I guess I'll put it back and rerun the entire fuzz suite to see what
> pops out...
Sure, I don't have objection on this patch, so you can have the RVB when
you change "local POPULATE_METADUMP_DESCR" to lower-case, and show at least
one example about why POPULATE_METADUMP need to be exported in next version.
No push:)
Reviewed-by: Zorro Lang <zlang@redhat.com>
Thanks,
Zorro
>
> --D
>
> > >
> > > > >
> > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > > > > ---
> > > > > common/populate | 6 +++---
> > > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > >
> > > > > diff --git a/common/populate b/common/populate
> > > > > index cfdaf766f0..b501c2fe45 100644
> > > > > --- a/common/populate
> > > > > +++ b/common/populate
> > > > > @@ -868,9 +868,9 @@ _scratch_populate_cached() {
> > > > > local meta_tag="$(echo "${meta_descr}" | md5sum - | cut -d ' ' -f 1)"
> > > > > local metadump_stem="${TEST_DIR}/__populate.${FSTYP}.${meta_tag}"
> > > > >
> > > > > - # These variables are shared outside this function
> > > > > - POPULATE_METADUMP="${metadump_stem}.metadump"
> > > > > - POPULATE_METADUMP_DESCR="${metadump_stem}.txt"
> > > > > + # This variable is shared outside this function
> > > > > + export POPULATE_METADUMP="${metadump_stem}.metadump"
> > > > > + local POPULATE_METADUMP_DESCR="${metadump_stem}.txt"
> > > >
> > > > If the POPULATE_METADUMP_DESCR is not shared outside anymore, how about change
> > > > it to lower-case?
> > >
> > > Ok.
> > >
> > > --D
> > >
> > > > >
> > > > > # Don't keep metadata images cached for more 48 hours...
> > > > > rm -rf "$(find "${POPULATE_METADUMP}" -mtime +2 2>/dev/null)"
> > > > >
> > > >
> > >
> >
>
next prev parent reply other threads:[~2022-10-14 1:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 1:45 [PATCHSET 0/5] fstests: support external logs when caching prepopulated images Darrick J. Wong
2022-10-12 1:45 ` [PATCH 1/5] populate: export the metadump description name Darrick J. Wong
2022-10-13 14:55 ` Zorro Lang
2022-10-13 15:54 ` Darrick J. Wong
2022-10-13 16:28 ` Zorro Lang
2022-10-13 19:12 ` Darrick J. Wong
2022-10-14 1:17 ` Zorro Lang [this message]
2022-10-14 18:21 ` [PATCH v1.1 " Darrick J. Wong
2022-10-15 5:01 ` Zorro Lang
2022-10-15 5:10 ` Zorro Lang
2022-10-15 7:28 ` Darrick J. Wong
2022-10-15 8:21 ` Zorro Lang
2022-10-15 7:23 ` Darrick J. Wong
2022-10-12 1:45 ` [PATCH 2/5] populate: wipe external xfs log devices when restoring a cached image Darrick J. Wong
2022-10-13 15:10 ` Zorro Lang
2022-10-12 1:45 ` [PATCH 3/5] populate: reformat external ext[34] journal " Darrick J. Wong
2022-10-13 15:47 ` Zorro Lang
2022-10-12 1:45 ` [PATCH 4/5] populate: require e2image before populating Darrick J. Wong
2022-10-13 15:48 ` Zorro Lang
2022-10-12 1:45 ` [PATCH 5/5] fstests: refactor xfs_mdrestore calls Darrick J. Wong
2022-10-13 16:06 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014011741.ky4bml5ythuv3svb@zlang-mailbox \
--to=zlang@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).